* Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit"
@ 2023-10-13 23:22 Younes Manton
2023-10-14 16:38 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Younes Manton @ 2023-10-13 23:22 UTC (permalink / raw)
To: stable
The following commit:
[babd04386b1df8c364cdaa39ac0e54349502e1e5] perf jit: Include program
header in ELF files
introduced a bug in perf that causes samples to be attributed to the
wrong instructions in the annotated assembly output of `perf report`
and `perf annotate`.
The following commit:
[89b15d00527b7825ff19130ed83478e80e3fae99] perf inject: Fix
GEN_ELF_TEXT_OFFSET for jit
fixes the bug.
Buggy commit is present in 4.19, 5.4, 5.10, and 5.15. The fix is in
6.1, 6.4, and 6.5. Can it also be backported to at least the 5.x
kernels, if not 4.19?
The output looks very confusing when parts of the code one expects to
accumulate ticks don't and other parts that shouldn't be executed at
all accumulate ticks.
I opened https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2020197
and was directed here, hopefully I understood the request correctly.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit"
2023-10-13 23:22 Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit" Younes Manton
@ 2023-10-14 16:38 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2023-10-14 16:38 UTC (permalink / raw)
To: Younes Manton; +Cc: stable
On Fri, Oct 13, 2023 at 07:22:02PM -0400, Younes Manton wrote:
>The following commit:
>
>[babd04386b1df8c364cdaa39ac0e54349502e1e5] perf jit: Include program
>header in ELF files
>
>introduced a bug in perf that causes samples to be attributed to the
>wrong instructions in the annotated assembly output of `perf report`
>and `perf annotate`.
>
>The following commit:
>
>[89b15d00527b7825ff19130ed83478e80e3fae99] perf inject: Fix
>GEN_ELF_TEXT_OFFSET for jit
>
>fixes the bug.
>
>Buggy commit is present in 4.19, 5.4, 5.10, and 5.15. The fix is in
>6.1, 6.4, and 6.5. Can it also be backported to at least the 5.x
>kernels, if not 4.19?
>
>The output looks very confusing when parts of the code one expects to
>accumulate ticks don't and other parts that shouldn't be executed at
>all accumulate ticks.
>
>I opened https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2020197
>and was directed here, hopefully I understood the request correctly.
>Thank you.
Queued up, thanks.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-14 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 23:22 Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit" Younes Manton
2023-10-14 16:38 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox