From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A249C4332F for ; Tue, 31 Oct 2023 11:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbjJaLLb (ORCPT ); Tue, 31 Oct 2023 07:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235946AbjJaLL3 (ORCPT ); Tue, 31 Oct 2023 07:11:29 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26BED10F6 for ; Tue, 31 Oct 2023 04:10:58 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40859c464daso43333955e9.1 for ; Tue, 31 Oct 2023 04:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698750656; x=1699355456; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vNOi5JlhvmPgexOpe6e7sYP0SS0+wpx4espISANvQAc=; b=Wdf828L1ZHsZY87Psp9MHmrjc3zYsoU0s7FsjgRunXFRtYUSC3PdbYe+T55mJoDJKP 24oAdxpGwtz79k+Kn7Id26+KMbpWryao7HVA1CvpgzAcSbrx1vPq0SG5myVepumcp1xQ FkGDi7jIklPv3BiZJllVwkVHINHECKiNWrQFz8A4f03nTl7MeOmFKWbGjOeP8eYCRgew 0biFcj1gKuKp0vhg/ejwz0CvXXN6k3bp78IFUa/7YH3Y4WFTQp0dVAH6LW3NwkMD4Zgu LbKqwhVqQCi7yOHjpldWbBeNHyN9D7pMxv1Uz28rLt4Sfuh25mVbQbdS4aZFWoD8/ElP 8iEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698750656; x=1699355456; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vNOi5JlhvmPgexOpe6e7sYP0SS0+wpx4espISANvQAc=; b=P/5YR+OPM355YkBzGraM0ge9KfnbhD04jeg6wTXbrHFPKBhs6ycrNYBKiEtOUrU97w 5PxqC2xWLbzBAgrAkgNqiTGBep1uwpxKKWXBHOVZzBx+2SmTVysqi2OQiPPectAtssVj WlkN/ffN/9LOUn5K1xgTdlHMr1FdnX6DJW9kaNWmup9uE3Y4EW93to22alhd/VWmtRu6 +yUy87Ign6gKAvWvPyP/AJPZBhkeH4UvJJ5Qk6qrRExs/ACLgjzFabG9Z/caB86G8rvy iQWuHDu2y+iBc0X9ByTay4cAGQimXFml3qT/BxmLtoLaI9X2JupJPl69+M0dgw9LFvGb toqg== X-Gm-Message-State: AOJu0YzKScsZBbiy/JJc1i88RqOT29Xm6uLfncZ0NIHuv400vZIGtUYf mFEIQOZ40QR1N2IpoEWAI++EIDFyM9n/KA== X-Google-Smtp-Source: AGHT+IHNNeTA9uOpkkwR/e9I56YV7XxF9ZDj1XX6IvDgbrAxYc4BeV1HpAnYAeKauIsESQ/t73fiRg== X-Received: by 2002:a05:600c:4594:b0:405:3d04:5f52 with SMTP id r20-20020a05600c459400b004053d045f52mr9901035wmo.24.1698750656272; Tue, 31 Oct 2023 04:10:56 -0700 (PDT) Received: from localhost ([2001:171b:c9bb:4130:c056:27ff:fec4:81cb]) by smtp.gmail.com with ESMTPSA id z18-20020a5d6412000000b00327cd5e5ac1sm1286557wru.1.2023.10.31.04.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 04:10:55 -0700 (PDT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 425e5057; Tue, 31 Oct 2023 11:10:55 +0000 (UTC) Date: Tue, 31 Oct 2023 12:10:55 +0100 From: David Lazar To: Mario Limonciello Cc: stable@vger.kernel.org, Hans de Goede , Mark Pearson , Greg KH , Sasha Levin Subject: Re: [PATCH 6.5.y] platform/x86: Add s2idle quirk for more Lenovo laptops Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 30 Oct 2023 16:30, Mario Limonciello wrote: > In this case are there modifications or is a clean cherry-pick? If it's not > a clean cherry pick, why? This wasn't a clean cherry pick because the code has been moved from drivers/platform/x86/amd/pmc-quirks.c in 6.5.y to drivers/platform/x86/amd/pmc/pmc-quirks.c in 6.6.y. > If it's just missing another system in the quirk list it's cleaner to > backport that missing system and then have a clean pick. In this case (the 6.5 patch) there was no missing system in the quirks list. However, in the 6.1 version, the HP system *is* missing from the list (it looks like the patch that added that system wasn't backported to 6.1). But even adding that system wouldn't result in a clean cherry pick, given that the code had been moved once before from drivers/platform/x86/thinkpad_acpi.c in 6.1.y to drivers/platform/x86/amd/pmc-quirks.c in 6.5.y. I had refrained from adding the missing system also in order to stay close to the upstream patch. In any case, I see Sasha and Greg are already working on these patches, so I'll leave them alone for now, to not generate more work for them. Thanks for your help, everyone, and please let me know if there's anything else I should do. -=[david]=-