From: Carlos Llamas <cmllamas@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH 5.10 0/2] checkpatch: fix repeated word annoyance
Date: Thu, 14 Dec 2023 18:37:43 +0000 [thread overview]
Message-ID: <ZXtLdyHSamRjH94u@google.com> (raw)
In-Reply-To: <2023121442-cold-scraggly-f19b@gregkh>
On Thu, Dec 14, 2023 at 07:23:28PM +0100, Greg KH wrote:
> On Thu, Dec 14, 2023 at 06:15:02PM +0000, Carlos Llamas wrote:
> > The checkpatch.pl in v5.10.y still triggers lots of false positives for
> > REPEATED_WORD warnings, particularly for commit logs. Can we please
> > backport these two fixes?
>
> Why is older versions of checkpatch being used? Why not always use the
> latest version, much like perf is handled?
>
> No new code should be written against older kernels, so who is using
> this old tool?
This is a minor annoyance when working directly with the v5.10 stable
tree and doing e.g ./scripts/checkpatch.pl -g HEAD. I suppose it makes
sense to always prefer the top-of-tree scripts. However, this could be
inconvenient for some scenarios were master needs to be pulled
separately.
--
Carlos Llamas
next prev parent reply other threads:[~2023-12-14 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 18:15 [PATCH 5.10 0/2] checkpatch: fix repeated word annoyance Carlos Llamas
2023-12-14 18:15 ` [PATCH 5.10 1/2] checkpatch: add new exception to repeated word check Carlos Llamas
2023-12-14 18:31 ` Joe Perches
2023-12-14 18:52 ` Carlos Llamas
2023-12-14 18:15 ` [PATCH 5.10 2/2] checkpatch: fix false positives in REPEATED_WORD warning Carlos Llamas
2023-12-14 18:23 ` [PATCH 5.10 0/2] checkpatch: fix repeated word annoyance Greg KH
2023-12-14 18:37 ` Carlos Llamas [this message]
2023-12-15 7:15 ` Greg KH
2023-12-15 16:46 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXtLdyHSamRjH94u@google.com \
--to=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox