From: Leonardo Bras <leobras@redhat.com>
To: guoren@kernel.org
Cc: Leonardo Bras <leobras@redhat.com>,
linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, alexghiti@rivosinc.com, charlie@rivosinc.com,
xiao.w.wang@intel.com, david@redhat.com,
panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com,
willy@infradead.org, bjorn@rivosinc.com,
conor.dooley@microchip.com, cleger@rivosinc.com,
linux-riscv@lists.infradead.org,
Guo Ren <guoren@linux.alibaba.com>,
stable@vger.kernel.org
Subject: Re: [PATCH V3 2/4] riscv: mm: Fixup compat arch_get_mmap_end
Date: Fri, 22 Dec 2023 23:51:48 -0300 [thread overview]
Message-ID: <ZYZLRNlEpVXECyq9@LeoBras> (raw)
In-Reply-To: <20231222115703.2404036-3-guoren@kernel.org>
On Fri, Dec 22, 2023 at 06:57:01AM -0500, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> When the task is in COMPAT mode, the arch_get_mmap_end should be 2GB,
> not TASK_SIZE_64. The TASK_SIZE has contained is_compat_mode()
> detection, so change the definition of STACK_TOP_MAX to TASK_SIZE
> directly.
>
> Cc: stable@vger.kernel.org
> Fixes: add2cc6b6515 ("RISC-V: mm: Restrict address space for sv39,sv48,sv57")
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> ---
> arch/riscv/include/asm/processor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm/processor.h
> index f19f861cda54..e1944ff0757a 100644
> --- a/arch/riscv/include/asm/processor.h
> +++ b/arch/riscv/include/asm/processor.h
> @@ -16,7 +16,7 @@
>
> #ifdef CONFIG_64BIT
> #define DEFAULT_MAP_WINDOW (UL(1) << (MMAP_VA_BITS - 1))
> -#define STACK_TOP_MAX TASK_SIZE_64
> +#define STACK_TOP_MAX TASK_SIZE
>
> #define arch_get_mmap_end(addr, len, flags) \
> ({ \
> --
> 2.40.1
>
LGTM.
FWIW:
Reviewed-by: Leonardo Bras <leobras@redhat.com>
next prev parent reply other threads:[~2023-12-23 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231222115703.2404036-1-guoren@kernel.org>
2023-12-22 11:57 ` [PATCH V3 1/4] riscv: mm: Fixup compat mode boot failure guoren
2023-12-23 2:57 ` Leonardo Bras
2023-12-23 3:07 ` Guo Ren
2023-12-23 3:36 ` Charlie Jenkins
2023-12-22 11:57 ` [PATCH V3 2/4] riscv: mm: Fixup compat arch_get_mmap_end guoren
2023-12-23 2:51 ` Leonardo Bras [this message]
2023-12-23 3:39 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYZLRNlEpVXECyq9@LeoBras \
--to=leobras@redhat.com \
--cc=alexghiti@rivosinc.com \
--cc=bjorn@rivosinc.com \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=david@redhat.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=panqinglin2020@iscas.ac.cn \
--cc=paul.walmsley@sifive.com \
--cc=rick.p.edgecombe@intel.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox