From: Sasha Levin <sashal@kernel.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org,
smfrench@gmail.com, Steve French <stfrench@microsoft.com>
Subject: Re: [PATCH 5.15.y 1/8] ksmbd: add support for key exchange
Date: Tue, 26 Dec 2023 18:01:01 -0500 [thread overview]
Message-ID: <ZYtbLYw2xyQRG8Md@sashalap> (raw)
In-Reply-To: <CAKYAXd-ujQ5-X4T7SeoUUoBVhhtqcdZujkcCoPrXu5245ORY2w@mail.gmail.com>
On Wed, Dec 27, 2023 at 05:05:10AM +0900, Namjae Jeon wrote:
>2023-12-26 23:59 GMT+09:00, Sasha Levin <sashal@kernel.org>:
>> On Tue, Dec 26, 2023 at 07:53:26PM +0900, Namjae Jeon wrote:
>>>[ Upstream commit f9929ef6a2a55f03aac61248c6a3a987b8546f2a ]
>>>
>>>When mounting cifs client, can see the following warning message.
>>>
>>>CIFS: decode_ntlmssp_challenge: authentication has been weakened as server
>>>does not support key exchange
>>>
>>>To remove this warning message, Add support for key exchange feature to
>>>ksmbd. This patch decrypts 16-byte ciphertext value sent by the client
>>>using RC4 with session key. The decrypted value is the recovered secondary
>>>key that will use instead of the session key for signing and sealing.
>>>
>>>Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
>>>Signed-off-by: Steve French <stfrench@microsoft.com>
>>>---
>>> fs/Kconfig | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>>diff --git a/fs/Kconfig b/fs/Kconfig
>>>index a6313a969bc5..971339ecc1a2 100644
>>>--- a/fs/Kconfig
>>>+++ b/fs/Kconfig
>>>@@ -369,8 +369,8 @@ source "fs/ksmbd/Kconfig"
>>>
>>> config SMBFS_COMMON
>>> tristate
>>>- default y if CIFS=y
>>>- default m if CIFS=m
>>>+ default y if CIFS=y || SMB_SERVER=y
>>>+ default m if CIFS=m || SMB_SERVER=m
>>>
>>> source "fs/coda/Kconfig"
>>> source "fs/afs/Kconfig"
>>
>> This looks really weird: the hunk above is in the original upstream
>> patch, but what happened to the rest of the upstream code?
>>
>> This change doesn't do what the message describing it says it does.
>There was a problem(omitted some changes) in the previous backport
>patch, I didn't know what to do, so I just sent a patch like this.
>Should I add it again after reverting the patch or just updating the
>patch description?
Given that this was due to an issue with the backport, I'd say just
write a new commit message explaining what happened, and point the fixes
tag to c5049d2d73b2 ("ksmbd: add support for key exchange")
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-12-26 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 10:53 [PATCH 5.15.y 0/8] Additional ksmbd backport patches for linux-5.15.y Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 1/8] ksmbd: add support for key exchange Namjae Jeon
2023-12-26 14:59 ` Sasha Levin
2023-12-26 20:05 ` Namjae Jeon
2023-12-26 23:01 ` Sasha Levin [this message]
2023-12-26 23:12 ` Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 2/8] ksmbd: set epoch in create context v2 lease Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 3/8] ksmbd: set v2 lease capability Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 4/8] ksmbd: downgrade RWH lease caching state to RH for directory Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 5/8] ksmbd: send v2 lease break notification " Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 6/8] ksmbd: lazy v2 lease break on smb2_write() Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 7/8] ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack() Namjae Jeon
2023-12-26 10:53 ` [PATCH 5.15.y 8/8] ksmbd: fix wrong allocation size update in smb2_open() Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYtbLYw2xyQRG8Md@sashalap \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linkinjeon@kernel.org \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox