From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: "Krishna chaitanya chundru" <quic_krichai@quicinc.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Brian Masney" <bmasney@redhat.com>,
"Georgi Djakov" <djakov@kernel.org>,
linux-arm-msm@vger.kernel.org, vireshk@kernel.org,
quic_vbadigan@quicinc.com, quic_skananth@quicinc.com,
quic_nitegupt@quicinc.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v6 3/6] PCI: qcom: Add missing icc bandwidth vote for cpu to PCIe path
Date: Tue, 16 Jan 2024 11:54:37 +0100 [thread overview]
Message-ID: <ZaZgba6wSMtuHz7i@hovoldconsulting.com> (raw)
In-Reply-To: <c278d89d-4eba-4ea7-8cf5-6b1de90dedbe@linaro.org>
On Fri, Jan 12, 2024 at 11:37:03PM +0100, Konrad Dybcio wrote:
> On 12.01.2024 16:59, Johan Hovold wrote:
> > On Fri, Jan 12, 2024 at 07:52:02PM +0530, Krishna chaitanya chundru wrote:
> >> CPU-PCIe path consits for registers PCIe BAR space, config space.
> >
> > consits?
> >
> >> As there is less access on this path compared to pcie to mem path
> >> add minimum vote i.e GEN1x1 bandwidth always.
> >
> > gen1 bandwidth can't be right.
> >
> >> In suspend remove the cpu vote after register space access is done.
> >>
> >> Fixes: c4860af88d0c ("PCI: qcom: Add basic interconnect support")
> >> cc: stable@vger.kernel.org
> >
> > This does not look like a fix so drop the above.
> >
> > The commit you refer to explicitly left this path unconfigured for now
> > and only added support for the configuring the mem path as needed on
> > sc8280xp which otherwise would crash.
>
> I only sorta agree. I'd include a fixes tag but point it to either 8450
> addition or original driver introduction, as this is patching up a real
> hole (see my reply to Bryan).
Right, the above Fixes tag is not correct in any case.
And with a complete commit message it may be possible to tell whether
a Fixes tag is warranted or not.
Johan
next prev parent reply other threads:[~2024-01-16 10:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 14:21 [PATCH v6 0/6] PCI: qcom: Add support for OPP Krishna chaitanya chundru
2024-01-12 14:22 ` [PATCH v6 3/6] PCI: qcom: Add missing icc bandwidth vote for cpu to PCIe path Krishna chaitanya chundru
2024-01-12 15:17 ` Bryan O'Donoghue
2024-01-12 22:33 ` Konrad Dybcio
2024-01-16 10:52 ` Johan Hovold
2024-01-17 9:13 ` Konrad Dybcio
2024-01-16 4:52 ` Krishna Chaitanya Chundru
2024-01-16 10:06 ` Bryan O'Donoghue
2024-01-12 15:30 ` Dmitry Baryshkov
2024-01-16 4:57 ` Krishna Chaitanya Chundru
2024-01-17 6:39 ` Manivannan Sadhasivam
2024-01-29 14:10 ` Krishna Chaitanya Chundru
2024-01-12 15:59 ` Johan Hovold
2024-01-12 22:37 ` Konrad Dybcio
2024-01-16 10:54 ` Johan Hovold [this message]
2024-01-16 5:04 ` Krishna Chaitanya Chundru
2024-01-16 10:46 ` Johan Hovold
2024-01-12 16:47 ` Bjorn Helgaas
2024-01-16 5:06 ` Krishna Chaitanya Chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaZgba6wSMtuHz7i@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox