Re: [PATCH stable 6.1 2/2] bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25

[Jiri Olsa <olsajiri@gmail.com>]

On Wed, Jan 17, 2024 at 12:02:44PM +0100, Greg KH wrote:
> On Wed, Jan 17, 2024 at 10:44:24AM +0100, Jiri Olsa wrote:
> > From: Alan Maguire <alan.maguire@oracle.com>
> > 
> > commit 7b99f75942da332e3f4f865e55a10fec95a30d4f upstream.
> > 
> > v1.25 of pahole supports filtering out functions with multiple inconsistent
> > function prototypes or optimized-out parameters from the BTF representation.
> > These present problems because there is no additional info in BTF saying which
> > inconsistent prototype matches which function instance to help guide attachment,
> > and functions with optimized-out parameters can lead to incorrect assumptions
> > about register contents.
> > 
> > So for now, filter out such functions while adding BTF representations for
> > functions that have "."-suffixes (foo.isra.0) but not optimized-out parameters.
> > This patch assumes that below linked changes land in pahole for v1.25.
> > 
> > Issues with pahole filtering being too aggressive in removing functions
> > appear to be resolved now, but CI and further testing will confirm.
> > 
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > Link: https://lore.kernel.org/r/20230510130241.1696561-1-alan.maguire@oracle.com
> > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > ---
> >  scripts/pahole-flags.sh | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Again, a signed-off-by please.
> 
> Resend the whole series?

ah right.. sure, np

jirka