From: Daniel Golle <daniel@makrotopia.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Frank Wunderlich <linux@fw-web.de>,
Markus Schneider-Pargmann <msp@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
Date: Wed, 31 Jan 2024 05:17:14 +0000 [thread overview]
Message-ID: <ZbnX2vfcalNL3yRV@makrotopia.org> (raw)
In-Reply-To: <20230913083529.3bgjl6rvfmixgjnd@blmsp>
Hi everyone!
On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Reading thermal sensor on mt7986 devices returns invalid temperature:
> >
> > bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> > -274000
> >
> > Fix this by adding missing members in mtk_thermal_data struct which were
> > used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Daniel Golle <daniel@makrotopia.org>
Kind ping to thermal and mediatek maintainers, please merge this patch.
https://patchwork.kernel.org/project/linux-pm/patch/20230907112018.52811-1-linux@fw-web.de/
https://patchwork.kernel.org/project/linux-mediatek/patch/20230907112018.52811-1-linux@fw-web.de/
>
> Thanks for fixing!
>
> Best,
> Markus
>
> > ---
> > drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> > index 843214d30bd8..967b9a1aead4 100644
> > --- a/drivers/thermal/mediatek/auxadc_thermal.c
> > +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> > .adcpnp = mt7986_adcpnp,
> > .sensor_mux_values = mt7986_mux_values,
> > .version = MTK_THERMAL_V3,
> > + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> > + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> > + .apmixed_buffer_ctl_set = BIT(0),
> > };
> >
> > static bool mtk_thermal_temp_is_valid(int temp)
> > --
> > 2.34.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2024-01-31 5:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 11:20 [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896 Frank Wunderlich
2023-09-07 11:36 ` AngeloGioacchino Del Regno
2023-09-13 8:35 ` Markus Schneider-Pargmann
2024-01-31 5:17 ` Daniel Golle [this message]
2024-01-31 8:08 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbnX2vfcalNL3yRV@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=amitk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox