public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Vlastimil Babka <vbabka@suse.cz>,
	kernel list <linux-kernel@vger.kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Oleksandr Natalenko <oleksandr@natalenko.name>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	Jiri Benc <jbenc@redhat.com>, Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: stable-kernel-rules was Re: fs/bcachefs/
Date: Thu, 22 Feb 2024 20:19:06 +0100	[thread overview]
Message-ID: <ZdeeKiTXc7WidRcs@duo.ucw.cz> (raw)
In-Reply-To: <aaf2f030-b6f4-437b-bb4e-79aa4891ae56@suse.cz>

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

Hi!

> > Personally I think we are not taking enough, and are still missing real
> > fixes.  Overall, this is only a very small % of what goes into Linus's
> > tree every day, so by that measure alone, we know we are missing things.
> 
> What % of what goes into Linus's tree do you think fits within the rules
> stated in Documentation/process/stable-kernel-rules.rst ? I don't know but
> "very small" would be my guess, so we should be fine as it is?
> 
> Or are the rules actually still being observed? I doubt e.g. many of the
> AUTOSEL backports fit them? Should we rename the file to
> stable-rules-nonsense.rst?

There seems to be just one rule being observed: "It or an equivalent
fix must already exist in Linus' tree (upstream).". Every other rule is
broken pretty much all the time.

AUTOSEL is a problem.

Plus there's problem with dependencies -- if a patch A is need for fix
B, the rules pretty much go out of the window, huge patches are
applied, whitespace fixes are applied, etc.

There are even known-bad patches being applied, and then
reverted. Greg explained that it heps his process somehow.

For example in 6.1.53 review, my notes say 30% of the patches did not
match the documented rules. 42% for v6.1.76.

OTOH ammount of patches that cause "real" problems is not that great,
and we seem to have enough testing. Still, updating the documentation
to match the reality would be good (perhaps explaining that stable
does not have manpower to re-do the dependencies, and how "apply bad
and revert" works).

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2024-02-22 19:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 22:12 fs/bcachefs/ Kent Overstreet
2024-01-15 23:03 ` fs/bcachefs/ Sasha Levin
2024-02-20 17:23   ` fs/bcachefs/ Kent Overstreet
2024-02-20 18:03     ` fs/bcachefs/ Greg KH
2024-02-20 18:53       ` fs/bcachefs/ Greg KH
2024-02-20 20:06         ` fs/bcachefs/ Kent Overstreet
2024-02-20 20:19           ` fs/bcachefs/ Greg KH
2024-02-20 20:22             ` fs/bcachefs/ Kent Overstreet
2024-02-20 20:39               ` fs/bcachefs/ Greg KH
2024-02-20 20:42                 ` fs/bcachefs/ Kent Overstreet
2024-02-20 20:39             ` fs/bcachefs/ Kent Overstreet
2024-02-20 20:51               ` fs/bcachefs/ Greg KH
2024-02-20 21:00                 ` fs/bcachefs/ Kent Overstreet
2024-02-21 14:53                   ` fs/bcachefs/ Greg KH
2024-02-21 16:00                     ` fs/bcachefs/ Oleksandr Natalenko
2024-02-21 17:57                       ` fs/bcachefs/ Greg KH
2024-02-21 18:10                         ` fs/bcachefs/ Vlastimil Babka
2024-02-21 20:52                           ` fs/bcachefs/ Kent Overstreet
2024-02-21 22:58                           ` fs/bcachefs/ Sasha Levin
2024-02-21 23:12                             ` fs/bcachefs/ Kent Overstreet
2024-02-22  5:48                               ` fs/bcachefs/ Greg KH
2024-02-22  6:30                                 ` fs/bcachefs/ Kent Overstreet
2024-02-22 11:54                                   ` fs/bcachefs/ Sasha Levin
2024-02-21 23:47                             ` fs/bcachefs/ Oleksandr Natalenko
2024-02-22 19:19                           ` Pavel Machek [this message]
2024-02-22 22:33                             ` stable-kernel-rules was fs/bcachefs/ Kent Overstreet
2024-02-23 18:50                               ` Pavel Machek
2024-02-20 19:36     ` fs/bcachefs/ Sasha Levin
2024-01-16 14:13 ` fs/bcachefs/ Greg KH
2024-01-16 17:26   ` fs/bcachefs/ Kent Overstreet
2024-01-16 17:44     ` fs/bcachefs/ Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdeeKiTXc7WidRcs@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbenc@redhat.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=regressions@leemhuis.info \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox