From: Christoph Hellwig <hch@infradead.org>
To: Boris Burkov <boris@bur.io>
Cc: Christoph Hellwig <hch@infradead.org>,
Anand Jain <anand.jain@oracle.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: validate device maj:min during open
Date: Fri, 8 Mar 2024 09:42:56 -0800 [thread overview]
Message-ID: <ZetOIKNJRsdFNJ3A@infradead.org> (raw)
In-Reply-To: <20240308173254.GA2469063@zen.localdomain>
On Fri, Mar 08, 2024 at 09:32:54AM -0800, Boris Burkov wrote:
> You remove/add the device in a way that results in a new bd_dev while
> the filesystem is unmounted but btrfs is still caching the struct
> btrfs_device. When we unmount a multi-device fs, we don't clear the
> device cache, since we need it to remount with just one device name
> later.
>
> The mechanism I used for getting a different bd_dev was partitioning two
> different devices in two different orders.
Ok, so we have a btrfs_device without a bdev around, which seems a bit
dangerous. Also relying on the dev_t for any kind of device identify
seems very dangerous. Aren't there per-device UUIDs or similar
identifiers that are actually reliabe and can be used instead of the
dev_t?
next prev parent reply other threads:[~2024-03-08 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 2:45 [PATCH v2] btrfs: validate device maj:min during open Anand Jain
2024-03-08 15:48 ` Christoph Hellwig
2024-03-08 16:04 ` Anand Jain
2024-03-08 16:10 ` Christoph Hellwig
2024-03-08 16:23 ` Anand Jain
2024-03-08 17:23 ` Christoph Hellwig
2024-03-08 17:32 ` Boris Burkov
2024-03-08 17:42 ` Christoph Hellwig [this message]
2024-03-08 17:51 ` Boris Burkov
2024-03-13 16:24 ` Anand Jain
2024-03-08 17:41 ` Boris Burkov
2024-03-12 19:17 ` Boris Burkov
2024-03-13 10:25 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZetOIKNJRsdFNJ3A@infradead.org \
--to=hch@infradead.org \
--cc=anand.jain@oracle.com \
--cc=boris@bur.io \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox