Re: [PATCH AUTOSEL 4.19 1/4] x86/mm: Move is_vsyscall_vaddr() into asm/vsyscall.h

Pavel Machek
2024-03-11T21:12:04Z

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

Hi!

> Move is_vsyscall_vaddr() into asm/vsyscall.h to make it available for
> copy_from_kernel_nofault_allowed() in arch/x86/mm/maccess.c.

This seems to be just part of a patch -- it does not move anything --
and we should not really need it for 4.19, as we don't have those
copy_from_kernel_nofault_allowed changes.

Best regards,
Pavel

> +++ b/arch/x86/include/asm/vsyscall.h
> @@ -4,6 +4,7 @@
>
> #include <linux/seqlock.h>
> #include <uapi/asm/vsyscall.h>
> +#include <asm/page_types.h>
>
> #ifdef CONFIG_X86_VSYSCALL_EMULATION
> extern void map_vsyscall(void);
> @@ -22,4 +23,13 @@ static inline bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
> }
> #endif
>
> +/*
> + * The (legacy) vsyscall page is the long page in the kernel portion
> + * of the address space that has user-accessible permissions.
> + */
> +static inline bool is_vsyscall_vaddr(unsigned long vaddr)
> +{
> + return unlikely((vaddr & PAGE_MASK) == VSYSCALL_ADDR);
> +}
> +
> #endif /* _ASM_X86_VSYSCALL_H */

--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]