Re: [PATCH 5.10 000/122] 5.10.211-rc1 review

Greg Kroah-Hartman
2024-02-28T06:03:48Z

On Tue, Feb 27, 2024 at 12:56:00PM -0600, Daniel Díaz wrote:
> Hello!
>
> On 27/02/24 7:26 a. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.211 release.
> > There are 122 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> We're seeing new warnings on 32-bits architectures: Arm, i386, PowerPC, RISC-V and System/390:
>
> -----8<-----
> builds/linux/net/ipv4/arp.c: In function 'arp_req_get':
> /builds/linux/include/linux/minmax.h:20:35: warning: comparison of distinct pointer types lacks a cast
> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> | ^~
> /builds/linux/include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> | ^~~~~~~~~~~
> /builds/linux/include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> | ^~~~~~~~~~
> /builds/linux/include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> 45 | #define min(x, y) __careful_cmp(x, y, <)
> | ^~~~~~~~~~~~~
> /builds/linux/net/ipv4/arp.c:1108:32: note: in expansion of macro 'min'
> 1108 | min(dev->addr_len, sizeof(r->arp_ha.sa_data_min)));
> | ^~~
> ----->8-----
>
> Bisection points to:
>
> commit 5a2d57992eca13530ac79ae287243b3ff6b01128
> Author: Kuniyuki Iwashima <kuniyu@amazon.com>
> Date: Thu Feb 15 15:05:16 2024 -0800
>
> arp: Prevent overflow in arp_req_get().
> commit a7d6027790acea24446ddd6632d394096c0f4667 upstream.

Ugh, I fixed this up for 5.15, but forgot to do so for older kernels, my
fault. I'll go update it now.

thanks,

greg k-h