[PATCH] net: wan: framer: Add missing static inline qualifiers

[PATCH] net: wan: framer: Add missing static inline qualifiers

[Herve Codina]

Compilation with CONFIG_GENERIC_FRAMER disabled lead to the following
warnings:
  framer.h:184:16: warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
  184 | struct framer *framer_get(struct device *dev, const char *con_id)
  framer.h:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  184 | struct framer *framer_get(struct device *dev, const char *con_id)
  framer.h:189:6: warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
  189 | void framer_put(struct device *dev, struct framer *framer)
  framer.h:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  189 | void framer_put(struct device *dev, struct framer *framer)

Add missing 'static inline' qualifiers for these functions.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403241110.hfJqeJRu-lkp@intel.com/
Fixes: 82c944d05b1a ("net: wan: Add framer framework support")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---

The error raised by the kernel test robot is already fixed by the
commit badc9e33c795 ("net: wan: fsl_qmc_hdlc: Fix module compilation")

 include/linux/framer/framer.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/framer/framer.h b/include/linux/framer/framer.h
index 9a9b88962c29..2b85fe9e7f9a 100644
--- a/include/linux/framer/framer.h
+++ b/include/linux/framer/framer.h
@@ -181,12 +181,12 @@ static inline int framer_notifier_unregister(struct framer *framer,
 	return -ENOSYS;
 }
 
-struct framer *framer_get(struct device *dev, const char *con_id)
+static inline struct framer *framer_get(struct device *dev, const char *con_id)
 {
 	return ERR_PTR(-ENOSYS);
 }
 
-void framer_put(struct device *dev, struct framer *framer)
+static inline void framer_put(struct device *dev, struct framer *framer)
 {
 }
 
-- 
2.44.0

Re: [PATCH] net: wan: framer: Add missing static inline qualifiers

[Andy Shevchenko]

On Mon, Mar 25, 2024 at 09:25:05AM +0100, Herve Codina wrote:
> Compilation with CONFIG_GENERIC_FRAMER disabled lead to the following
> warnings:
>   framer.h:184:16: warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:189:6: warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
>   189 | void framer_put(struct device *dev, struct framer *framer)
>   framer.h:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   189 | void framer_put(struct device *dev, struct framer *framer)

Always try to minimize the warnings/backtraces/etc to the point. In this case
it's enough to have:

  warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
  warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]

> Add missing 'static inline' qualifiers for these functions.

Code wise looks good,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] net: wan: framer: Add missing static inline qualifiers

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 25 Mar 2024 09:25:05 +0100 you wrote:
> Compilation with CONFIG_GENERIC_FRAMER disabled lead to the following
> warnings:
>   framer.h:184:16: warning: no previous prototype for function 'framer_get' [-Wmissing-prototypes]
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:184:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   184 | struct framer *framer_get(struct device *dev, const char *con_id)
>   framer.h:189:6: warning: no previous prototype for function 'framer_put' [-Wmissing-prototypes]
>   189 | void framer_put(struct device *dev, struct framer *framer)
>   framer.h:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   189 | void framer_put(struct device *dev, struct framer *framer)
> 
> [...]

Here is the summary with links:
  - net: wan: framer: Add missing static inline qualifiers
    https://git.kernel.org/netdev/net/c/ea2c09283b44

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html