Re: [PATCH RESEND 0/2] usb: typec: tipd: fix event checking in interrupt service routines

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Thu, Mar 28, 2024 at 05:55:50PM +0100, Javier Carrasco wrote:
> The ISRs of the tps25750 and tps6598x do not handle generated events
> properly under all circumstances.
> 
> The tps6598x ISR does not read all bits of the INT_EVENTX registers,
> leaving events signaled with bits above 64 unattended. Moreover, these
> events are not cleared, leaving the interrupt enabled.
> 
> The tps25750 reads all bits of the INT_EVENT1 register, but the event
> checking is not right because the same event is checked in two different
> regions of the same register by means of an OR operation.
> 
> This series aims to fix both issues by reading all bits of the
> INT_EVENTX registers, and limiting the event checking to the region
> where the supported events are defined (currently they are limited to
> the first 64 bits of the registers, as the are defined as BIT_ULL()).
> 
> If the need for events above the first 64 bits of the INT_EVENTX
> registers arises, a different mechanism might be required. But for the
> current needs, all definitions can be left as they are.
> 
> Note: resend to add the Cc tag for 'stable' (fixes in the series).

So this should be v3 (or v2?). Next time please follow the guide
when submitting patches:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

thanks,

-- 
heikki