From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2C53BBFE; Sun, 7 Apr 2024 23:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712533726; cv=none; b=LnHIrWg1C0Dr+h/KNVX/DMgBVExzNJtprtZU9ddJufoiY1KwnB/GPtIn2ysWk4CImW4+W4potDrDzYPiXi7cZ5NTlocYlDlltQHDUMV2lTXJVKKZp46B2SeW+vwCtdo5GBjCdCgmQKZ8hgqa5gV3YLglKdcMXbIESU6aW4PLPMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712533726; c=relaxed/simple; bh=JIrH3QsMT/5WGDUR8zfqWVuCSjEhK7gh8q5viWx6UEQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jAKg7AK8v6p/EnZcSygP/hEmdgG4vBA0UC4MFvj0YJ3HT3+Hk+6mM+/R+shSRpeIphPdiDlYHeyw7XZQXgfFYXSp4Ob784SJg3VkRhGlhMgqmdiSZuJiqCgZd6s0MfqbcwvUxsdbwk5eaLIywMJk5y/jwK9V6awlCL3MxX9227M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FhKXL9sF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FhKXL9sF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 251CDC433F1; Sun, 7 Apr 2024 23:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712533726; bh=JIrH3QsMT/5WGDUR8zfqWVuCSjEhK7gh8q5viWx6UEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FhKXL9sFQo+5bfApgbfZdE7MSjQTZHQjlN1uNH0tDYsGQ+NyFjdgRWjgtmvXQZyPr mUe7CesVOmRJh2fgA2+MXXM3cr1k2xez/LJXjGJDUwJei85jxyGD3fm2JXlhHy7t6J LQeiXbmOt6s1WRl6ToLDQmY5QOf4E3bIGrQdf9YLXY9ynApXQGdUu4fcTODt9G3IvQ 4YkcNk8ep8uGd6XfRc033x568sdK+Pb4TmZMdgHvY7RBHCkbNshIpobPRQ62tKfdjz hEZb7FEBZrJuFa/yJsJriUMXp/W7Q2VruxXs/Wvfi9Si9DTHW8DiFL9RA8S4g/8TVt dHcWiMFhhh2uQ== Date: Sun, 7 Apr 2024 19:48:45 -0400 From: Sasha Levin To: Karel Balej Cc: Markuss Broks , Dmitry Torokhov , linux-input@vger.kernel.org, duje.mihanovic@skole.hr, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.8 78/98] input/touchscreen: imagis: add support for IST3032C Message-ID: References: <20240329123919.3087149-1-sashal@kernel.org> <20240329123919.3087149-78-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Sat, Mar 30, 2024 at 10:33:53AM +0100, Karel Balej wrote: >Sasha, > >Sasha Levin, 2024-03-29T08:37:49-04:00: >> From: Karel Balej >> >> [ Upstream commit 90cb57a6c5717b83a110c0da720a03ee32ed255e ] >> >> IST3032C is a touchscreen chip used for instance in the >> samsung,coreprimevelte smartphone, with which this was tested. Add the >> chip specific information to the driver. >> >> Reviewed-by: Markuss Broks >> Signed-off-by: Karel Balej >> Link: https://lore.kernel.org/r/20240301164659.13240-6-karelb@gimli.ms.mff.cuni.cz >> Signed-off-by: Dmitry Torokhov >> Signed-off-by: Sasha Levin >> --- >> drivers/input/touchscreen/imagis.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c >> index 9af8a6332ae67..e1fafa561ee38 100644 >> --- a/drivers/input/touchscreen/imagis.c >> +++ b/drivers/input/touchscreen/imagis.c >> @@ -11,6 +11,8 @@ >> #include >> #include >> >> +#define IST3032C_WHOAMI 0x32c >> + >> #define IST3038B_REG_STATUS 0x20 >> #define IST3038B_REG_CHIPID 0x30 >> #define IST3038B_WHOAMI 0x30380b >> @@ -363,6 +365,13 @@ static int imagis_resume(struct device *dev) >> >> static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume); >> >> +static const struct imagis_properties imagis_3032c_data = { >> + .interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE, >> + .touch_coord_cmd = IST3038C_REG_TOUCH_COORD, >> + .whoami_cmd = IST3038C_REG_CHIPID, >> + .whoami_val = IST3032C_WHOAMI, >> +}; >> + >> static const struct imagis_properties imagis_3038b_data = { >> .interrupt_msg_cmd = IST3038B_REG_STATUS, >> .touch_coord_cmd = IST3038B_REG_STATUS, >> @@ -380,6 +389,7 @@ static const struct imagis_properties imagis_3038c_data = { >> >> #ifdef CONFIG_OF >> static const struct of_device_id imagis_of_match[] = { >> + { .compatible = "imagis,ist3032c", .data = &imagis_3032c_data }, >> { .compatible = "imagis,ist3038b", .data = &imagis_3038b_data }, >> { .compatible = "imagis,ist3038c", .data = &imagis_3038c_data }, >> { }, >> -- >> 2.43.0 > >sorry if I'm missing something, but I don't see why this should be >backported: it doesn't fix anything, it's just adding support for new >hardware. > >I can see that adding a device ID is permitted for -stable [1], but I >thought it still has to bear some signs of a fix, such as maybe here >[2]. It does not need to be a fix, it could just be plain device enablement. -- Thanks, Sasha