Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
	ojeda@kernel.org, "Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@samsung.com>,
	"Alice Ryhl" <aliceryhl@google.com>
Subject: Re: Patch "kbuild: rust: force `alloc` extern to allow "empty" Rust files" has been added to the 6.1-stable tree
Date: Tue, 7 May 2024 19:00:03 -0400	[thread overview]
Message-ID: <Zjqyc-hu1GDlbGBa@sashalap> (raw)
In-Reply-To: <CANiq72=V1=D-X5ncqN1pyfE4L1bz5zFRdBot6HpkCYie-EQnPA@mail.gmail.com>

On Fri, May 03, 2024 at 07:10:35PM +0200, Miguel Ojeda wrote:
>On Fri, May 3, 2024 at 6:42 PM Sasha Levin <sashal@kernel.org> wrote:
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>
>I don't think it should be added since it requires upgrading the
>compiler to Rust 1.71 (from 1.62) at least, given:
>
>>     be fairly confusing for kernel developers [1], thus use the unstable
>>     `force` option of `--extern` [2] (added in Rust 1.71 [3]) to force the
>>     compiler to resolve `alloc`.
>
>Now, we have upgraded the compiler in the past (in 6.6 LTS), so it
>could be done, but the issue here was small enough (it should only
>really affect kernel developers if they happen to create a new file or
>similar) that it felt too minor to warrant it (especially since it
>would a bigger compiler jump this time, with more changes required
>too), so I asked for doing it only in 6.6 and 6.8 since those were
>straightforward:
>
>    https://lore.kernel.org/stable/2024042909-whimsical-drapery-40d1@gregkh/
>
>If someone is actually doing development in 6.1 LTS with Rust enabled,
>we may create bigger problems for them (even if it is just time used)
>by upgrading the compiler than what this fix fixes here (which is an
>issue they may not even care about or ever notice).

Dropped, thanks!

In general, it would be nice to have a mechanism that matches supported
Rust compilers with whatever is in the kernel tree. This logic of "6.6
is ok but 6.1 is too old" feels so 90s.

-- 
Thanks,
Sasha

  reply	other threads:[~2024-05-07 23:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240503164220.9073-1-sashal@kernel.org>
2024-05-03 17:10 ` Patch "kbuild: rust: force `alloc` extern to allow "empty" Rust files" has been added to the 6.1-stable tree Miguel Ojeda
2024-05-07 23:00   ` Sasha Levin [this message]
     [not found] <20240616021129.1681226-1-sashal@kernel.org>
2024-06-16 10:38 ` Miguel Ojeda
2024-06-19 10:58   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zjqyc-hu1GDlbGBa@sashalap \
    --to=sashal@kernel.org \
    --cc=a.hindborg@samsung.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=masahiroy@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=ojeda@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox