public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>, Greg Kurz <groug@kaod.org>,
	Jianyong Wu <jianyong.wu@arm.com>,
	stable@vger.kernel.org, Eric Van Hensbergen <ericvh@gmail.com>,
	v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: add missing locking around taking dentry fid list
Date: Thu, 23 May 2024 20:38:28 +0900	[thread overview]
Message-ID: <Zk8qtPVlhiJOZxek@codewreck.org> (raw)
In-Reply-To: <2675095.dNBKFZOyUv@silver>

Christian Schoenebeck wrote on Thu, May 23, 2024 at 12:05:44PM +0200:
> > I really think it's safe, but I do agree that it's hard to read, happy
> > to move the `h = &dentry->d_fsdata` inside the lock if you prefer -- it
> > compiles to the same code for me (x86_64/gcc 13.2.0)
> 
> No need, you can add my RB. Thanks for the clarification!
> 
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>

Thanks!
I've fixed the typo in the commit message and queued it up in -next,
will send this patch and the trace uninit fix to Linus early next week.

-- 
Dominique Martinet | Asmadeus

      reply	other threads:[~2024-05-23 11:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 12:29 [PATCH] 9p: add missing locking around taking dentry fid list Dominique Martinet
2024-05-22 14:35 ` Christian Schoenebeck
2024-05-22 17:25   ` Dominique Martinet
2024-05-23  8:34     ` Christian Schoenebeck
2024-05-23  9:27       ` Dominique Martinet
2024-05-23 10:05         ` Christian Schoenebeck
2024-05-23 11:38           ` Dominique Martinet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zk8qtPVlhiJOZxek@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=ericvh@gmail.com \
    --cc=ericvh@kernel.org \
    --cc=groug@kaod.org \
    --cc=jianyong.wu@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=stable@vger.kernel.org \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox