Re: [PATCH bpf v1 1/2] Compiler Attributes: Add __retain macro

Tony Ambardar
2024-06-04T02:38:01Z

On Mon, Jun 03, 2024 at 03:57:38PM +0200, Miguel Ojeda wrote:
> On Mon, Jun 3, 2024 at 2:16 PM Tony Ambardar <tony.ambardar@gmail.com> wrote:
> >
> > +#if __has_attribute(__retain__) && \
> > + (defined(CONFIG_LD_DEAD_CODE_DATA_ELIMINATION) || \
> > + defined(CONFIG_LTO_CLANG))
>
> Since this attribute depends on the configuration, please move it to
> `compiler_types.h` instead.

Noted and thanks for clarifying; I'll change in v2.

Cheers,
Tony

>
> Cheers,
> Miguel