From: Hangbin Liu <liuhangbin@gmail.com>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org,
petrm@nvidia.com, pabeni@redhat.com, kuba@kernel.org,
bpoirier@nvidia.com, idosch@nvidia.com
Subject: Re: [PATCHv2 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests
Date: Tue, 18 Jun 2024 17:19:40 +0800 [thread overview]
Message-ID: <ZnFRLEhSnMZalWN5@Laptop-X1> (raw)
In-Reply-To: <20240618075306.1073405-1-po-hsu.lin@canonical.com>
On Tue, Jun 18, 2024 at 03:53:03PM +0800, Po-Hsu Lin wrote:
> Since upstream commit:
> * 0f4765d0 "selftests/net: convert unicast_extensions.sh to run it in
> unique namespace"
> * 378f082e "selftests/net: convert pmtu.sh to run it in unique namespace"
>
> The lib.sh from commit 25ae948b "selftests/net: add lib.sh" will be needed.
> Otherwise these test will complain about missing files and fail:
> $ sudo ./unicast_extensions.sh
> ./unicast_extensions.sh: line 31: lib.sh: No such file or directory
> ...
>
> $ sudo ./pmtu.sh
> ./pmtu.sh: line 201: lib.sh: No such file or directory
> ./pmtu.sh: line 941: cleanup_all_ns: command not found
> ...
>
> Another commit b6925b4e "selftests/net: add variable NS_LIST for lib.sh" is
> needed to add support for the cleanup_all_ns above.
>
> And 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh" is
> a follow-up fix for tests inside the net/forwarding directory.
>
> V2: Add 2114e833 "selftests: forwarding: Avoid failures to source net/lib.sh"
> as suggested by Hangbin Liu.
>
> Benjamin Poirier (1):
> selftests: forwarding: Avoid failures to source net/lib.sh
>
> Hangbin Liu (2):
> selftests/net: add lib.sh
> selftests/net: add variable NS_LIST for lib.sh
>
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/forwarding/lib.sh | 52 +++++++--------
> tools/testing/selftests/net/lib.sh | 93 +++++++++++++++++++++++++++
> 3 files changed, 120 insertions(+), 27 deletions(-)
> create mode 100644 tools/testing/selftests/net/lib.sh
>
> --
> 2.7.4
>
For the series
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
prev parent reply other threads:[~2024-06-18 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 7:53 [PATCHv2 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests Po-Hsu Lin
2024-06-18 7:53 ` [PATCHv2 6.6.y 1/3] selftests/net: add lib.sh Po-Hsu Lin
2024-06-19 8:49 ` Greg KH
2024-06-18 7:53 ` [PATCHv2 6.6.y 2/3] selftests/net: add variable NS_LIST for lib.sh Po-Hsu Lin
2024-06-18 7:53 ` [PATCHv2 6.6.y 3/3] selftests: forwarding: Avoid failures to source net/lib.sh Po-Hsu Lin
2024-06-18 9:19 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnFRLEhSnMZalWN5@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=po-hsu.lin@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox