From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, lp610mh@gmail.com,
stable@vger.kernel.org, Tkd-Alex <alex.tkd.alex@gmail.com>
Subject: Re: [PATCH] ata: libata-core: Add ATA_HORKAGE_NOLPM for all Crucial BX SSD1 models
Date: Tue, 25 Jun 2024 10:52:03 +0200 [thread overview]
Message-ID: <ZnqFM9oulPGKqytO@ryzen.lan> (raw)
In-Reply-To: <82e310a4-5668-4edf-b3a8-2c7898a7c4cb@kernel.org>
On Tue, Jun 25, 2024 at 06:47:32AM +0900, Damien Le Moal wrote:
> On 2024/06/24 22:27, Niklas Cassel wrote:
> > We got another report that CT1000BX500SSD1 does not work with LPM.
> >
> > If you look in libata-core.c, we have six different Crucial devices that
> > are marked with ATA_HORKAGE_NOLPM. This model would have been the seventh.
> > (This quirk is used on Crucial models starting with both CT* and
> > Crucial_CT*)
> >
> > It is obvious that this vendor does not have a great history of supporting
> > LPM properly, therefore, add the ATA_HORKAGE_NOLPM quirk for all Crucial
> > BX SSD1 models.
> >
> > Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
> > Cc: stable@vger.kernel.org
> > Reported-by: Tkd-Alex <alex.tkd.alex@gmail.com>
>
> We need a real full name here, not a user name... So if Alex is not willing to
> send his full name, please remove this.
I disagree.
The Signed-off-by tag needs a real name, but if you take a dig through the
git log, you will see that the Reported-by tag is not always a real name.
E.g. the benevolent dictator for life used a non-real name for Reported-by
here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6022f210461fef67e6e676fd8544ca02d1bcfa7a
Anyway, now when we have a real name, I will send a V2.
Kind regards,
Niklas
prev parent reply other threads:[~2024-06-25 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 13:27 [PATCH] ata: libata-core: Add ATA_HORKAGE_NOLPM for all Crucial BX SSD1 models Niklas Cassel
2024-06-24 21:47 ` Damien Le Moal
2024-06-25 8:52 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnqFM9oulPGKqytO@ryzen.lan \
--to=cassel@kernel.org \
--cc=alex.tkd.alex@gmail.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=lp610mh@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox