* [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply
[not found] <20240722095459.27437-1-johan+linaro@kernel.org>
@ 2024-07-22 9:54 ` Johan Hovold
2024-07-22 10:02 ` Konrad Dybcio
2024-07-22 10:02 ` Abel Vesa
2024-07-22 9:54 ` [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios Johan Hovold
1 sibling, 2 replies; 5+ messages in thread
From: Johan Hovold @ 2024-07-22 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sibi Sankar,
Abel Vesa, Rajendra Nayak, Xilin Wu, Srinivas Kandagatla,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable
The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j) on the CRD so assume
the same applies to the QCP.
Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Cc: stable@vger.kernel.org # 6.9
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index e7758f172d0d..212ed20b3369 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -576,7 +576,7 @@ &pcie4 {
};
&pcie4_phy {
- vdda-phy-supply = <&vreg_l3j_0p8>;
+ vdda-phy-supply = <&vreg_l3i_0p8>;
vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
--
2.44.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios
[not found] <20240722095459.27437-1-johan+linaro@kernel.org>
2024-07-22 9:54 ` [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply Johan Hovold
@ 2024-07-22 9:54 ` Johan Hovold
2024-07-22 10:02 ` Konrad Dybcio
1 sibling, 1 reply; 5+ messages in thread
From: Johan Hovold @ 2024-07-22 9:54 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sibi Sankar,
Abel Vesa, Rajendra Nayak, Xilin Wu, Srinivas Kandagatla,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable
Add the missing PCIe4 perst, wake and clkreq GPIOs and pin config.
Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Cc: stable@vger.kernel.org # 6.9
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 29 +++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 998e5ea2f52e..786285af9f33 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -572,6 +572,12 @@ &mdss_dp3_phy {
};
&pcie4 {
+ perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
+ wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
+
+ pinctrl-0 = <&pcie4_default>;
+ pinctrl-names = "default";
+
status = "okay";
};
@@ -665,6 +671,29 @@ nvme_reg_en: nvme-reg-en-state {
bias-disable;
};
+ pcie4_default: pcie4-default-state {
+ clkreq-n-pins {
+ pins = "gpio147";
+ function = "pcie4_clk";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ perst-n-pins {
+ pins = "gpio146";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ wake-n-pins {
+ pins = "gpio148";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+ };
+
pcie6a_default: pcie6a-default-state {
clkreq-n-pins {
pins = "gpio153";
--
2.44.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply
2024-07-22 9:54 ` [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply Johan Hovold
@ 2024-07-22 10:02 ` Konrad Dybcio
2024-07-22 10:02 ` Abel Vesa
1 sibling, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-07-22 10:02 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sibi Sankar,
Abel Vesa, Rajendra Nayak, Xilin Wu, Srinivas Kandagatla,
linux-arm-msm, devicetree, linux-kernel, stable
On 22.07.2024 11:54 AM, Johan Hovold wrote:
> The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j) on the CRD so assume
> the same applies to the QCP.
>
> Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Cc: stable@vger.kernel.org # 6.9
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply
2024-07-22 9:54 ` [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply Johan Hovold
2024-07-22 10:02 ` Konrad Dybcio
@ 2024-07-22 10:02 ` Abel Vesa
1 sibling, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2024-07-22 10:02 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sibi Sankar, Rajendra Nayak, Xilin Wu,
Srinivas Kandagatla, linux-arm-msm, devicetree, linux-kernel,
stable
On 24-07-22 11:54:48, Johan Hovold wrote:
> The PCIe4 PHY is powered by vreg_l3i (not vreg_l3j) on the CRD so assume
> the same applies to the QCP.
>
> Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Cc: stable@vger.kernel.org # 6.9
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> index e7758f172d0d..212ed20b3369 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
> @@ -576,7 +576,7 @@ &pcie4 {
> };
>
> &pcie4_phy {
> - vdda-phy-supply = <&vreg_l3j_0p8>;
> + vdda-phy-supply = <&vreg_l3i_0p8>;
> vdda-pll-supply = <&vreg_l3e_1p2>;
>
> status = "okay";
> --
> 2.44.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios
2024-07-22 9:54 ` [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios Johan Hovold
@ 2024-07-22 10:02 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-07-22 10:02 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sibi Sankar,
Abel Vesa, Rajendra Nayak, Xilin Wu, Srinivas Kandagatla,
linux-arm-msm, devicetree, linux-kernel, stable
On 22.07.2024 11:54 AM, Johan Hovold wrote:
> Add the missing PCIe4 perst, wake and clkreq GPIOs and pin config.
>
> Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Cc: stable@vger.kernel.org # 6.9
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-22 10:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240722095459.27437-1-johan+linaro@kernel.org>
2024-07-22 9:54 ` [PATCH 01/12] arm64: dts: qcom: x1e80100-qcp: fix PCIe4 PHY supply Johan Hovold
2024-07-22 10:02 ` Konrad Dybcio
2024-07-22 10:02 ` Abel Vesa
2024-07-22 9:54 ` [PATCH 04/12] arm64: dts: qcom: x1e80100-qcp: fix missing PCIe4 gpios Johan Hovold
2024-07-22 10:02 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).