From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE13148302; Tue, 27 Aug 2024 15:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724772582; cv=none; b=UgrlKik4Y+urIfnt7HczHm48JnDe1lLRDxQXPDv9Qt/vT7JaLhulfzTilsYT0X5Ldb+YuZLvKj+gKeayiUJeQMmCGqqI3Uo3O8WY17ZnRODABcKrHlF+9+tQbcl9a59ujX0kZkM4qEmEscbL25AzDKwsiU38DDrn1Tu+bAeAfyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724772582; c=relaxed/simple; bh=9aW2onbiq5EWdt1zGOOLGyusFlqkV6Ndt0HXHadGScI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e3aydI7zdfu50mxH0/bikH22EnO9VpdX8ykG+Eo3uN49MFZLPM1wIKVxB3DMU1oC1NbLkNq47lJo+pB3QVy+1sGBdRNkkqwUcH7tIx4JP+9PxmTZZUQPfQ4pbWhKAPuUMEWJ7JHRnk7rWm5pPBwz8hH18g0K4CW2OjSngBRROrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BMZNf6vB; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BMZNf6vB" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-53349d3071eso6888377e87.2; Tue, 27 Aug 2024 08:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724772578; x=1725377378; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=f0CuVBUU188TFdCdCElDdpiQeiLNGXtDVDEZ4g9j024=; b=BMZNf6vBkLfMU62qzKvBFF8xrdW343TSwbZVPL8z4aqNN6Y9jo8EmtgFIvH+JX4l3u XBd4/rjlwjdplsP/WIuWZ92j9WgshBVpKVBDmM/xEqkIwoJQP+mwWtoXzLBJQzB9OyCN 9k8FK26mVZw637Fgz1IMRnvgAWoyU2Vkq91MpS66toaIh9NC+CPZubiLweOjhmEMHtNn sZYdfIvTThhn7BZwJrxSa1TueCg3MyA43vnBZOtlAlwQiP3NE05LVJYy++pHZqp2u+27 7mXptBR0fftO5Ju2TUI/j468a4k9yHbZenBXJy9ZWpOFZnR3kznWRLp4VrtcueVCPn1N Z36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724772578; x=1725377378; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0CuVBUU188TFdCdCElDdpiQeiLNGXtDVDEZ4g9j024=; b=mWkduCOOy8vpzodydAPu/Xae3agtDSl6k2UGjlewsPtXCsG3mGOQZFWSedmFW+D+HZ CQOTh6wcyrMVgmMNqYIY9A5N9wR+cm2tgVSx592hWX8APQNnTyDlDGHKDCbI0RIVVLRZ ITM/TjTZw5kltFahks9MIb2CgiTm8OlImH5oBUDQ1rPWcTC3FuhpyTbrAry95zYVPDW/ LPnF18WrXEWACUc2+l3hJ3hdCRDjg/FPWuXF0EKWicxOjSeMKCkSGfKvJmwRxi3sPosa emBeFacCWyyz4l21tZ8HxEAEfzFu3vQCSX3N24iQDeRznEXcClSwVXAOBsqFifCdaSSN qu5A== X-Forwarded-Encrypted: i=1; AJvYcCVlWsMAMCgZekwlWrA1EnYQB2lF/bLoz6yVscAwd7S+AJctDqBWJbB0bjAj7mcI1jTlAJeexKrV@vger.kernel.org, AJvYcCWbKVxb70ydWKMamQlB/2lH8vlWlUNVZ0tPLGMozOLVkCVNT1GWox2mgBjkTLHX0mAZMWAhq2pz6G6hVBU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0eEpr8jj0Rc1vBdfTva8Dd6JITMWJDzkzI1fMkPnI0XtUCWSj rORf6nyAEdKVlp9yn+jfTsWX1j3lOu97XMiP+gJo9d+g4JnbLN7Y X-Google-Smtp-Source: AGHT+IEIP68WxlCLDhys8pYQtHsPKoUPB4CYjjsRJozxWR4f23vWfH5GoC33jNXHu9c5dPW+mp3mkw== X-Received: by 2002:a05:6512:108b:b0:52e:768e:4d1f with SMTP id 2adb3069b0e04-534387858a6mr9416434e87.36.1724772577623; Tue, 27 Aug 2024 08:29:37 -0700 (PDT) Received: from pc636 (host-90-233-206-146.mobileonline.telia.com. [90.233.206.146]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5334ea5da51sm1826531e87.224.2024.08.27.08.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 08:29:37 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 27 Aug 2024 17:29:34 +0200 To: Michal Hocko Cc: Uladzislau Rezki , Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 27, 2024 at 03:37:38PM +0200, Michal Hocko wrote: > On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > > On Tue, Aug 26, 2024 at 08:49:35AM +0200, Michal Hocko wrote: > [...] > > > > 2. High-order allocations. Do you think we should not care much about > > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > > > What do you propose here? Fail such request? > > We shouldn't have any hard requirements for higher order allocations in the vmalloc > right? In other words we can always fallback to base pages. > We always drop NOFAIL for high-order, if it fails we fall-back to order-0. I got the feeling that you wanted just bail-out fully if high-order and NOFAIL. -- Uladzislau Rezki