From: Joerg Roedel <joro@8bytes.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>, Eliav Bar-ilan <eliavb@nvidia.com>,
Joerg Roedel <jroedel@suse.de>,
patches@lists.linux.dev, stable@vger.kernel.org,
Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH rc] iommu/amd: Fix argument order in amd_iommu_dev_flush_pasid_all()
Date: Thu, 12 Sep 2024 09:20:38 +0200 [thread overview]
Message-ID: <ZuKWRo567ZkmFjvq@8bytes.org> (raw)
In-Reply-To: <0-v1-fc6bc37d8208+250b-amd_pasid_flush_jgg@nvidia.com>
On Tue, Sep 10, 2024 at 04:44:16PM -0300, Jason Gunthorpe wrote:
> From: Eliav Bar-ilan <eliavb@nvidia.com>
>
> An incorrect argument order calling amd_iommu_dev_flush_pasid_pages()
> causes improper flushing of the IOMMU, leaving the old value of GCR3 from
> a previous process attached to the same PASID.
>
> The function has the signature:
>
> void amd_iommu_dev_flush_pasid_pages(struct iommu_dev_data *dev_data,
> ioasid_t pasid, u64 address, size_t size)
>
> Correct the argument order.
>
> Cc: stable@vger.kernel.org
> Fixes: 474bf01ed9f0 ("iommu/amd: Add support for device based TLB invalidation")
> Signed-off-by: Eliav Bar-ilan <eliavb@nvidia.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/iommu/amd/iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2024-09-12 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 19:44 [PATCH rc] iommu/amd: Fix argument order in amd_iommu_dev_flush_pasid_all() Jason Gunthorpe
2024-09-11 9:43 ` Vasant Hegde
2024-09-12 7:20 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuKWRo567ZkmFjvq@8bytes.org \
--to=joro@8bytes.org \
--cc=eliavb@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jroedel@suse.de \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).