* Re: [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
@ 2024-09-16 11:36 ` Abel Vesa
2024-09-16 23:31 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2024-09-16 11:36 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy, devicetree,
linux-kernel, stable
On 24-09-16 10:23:06, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the PCIe4 and
> PCIe6a PHYs.
>
> Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
> Cc: stable@vger.kernel.org # 6.9
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 0cf4f3c12428..53e7d1e603cb 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -2980,14 +2980,16 @@ pcie6a_phy: phy@1bfc000 {
>
> clocks = <&gcc GCC_PCIE_6A_PHY_AUX_CLK>,
> <&gcc GCC_PCIE_6A_CFG_AHB_CLK>,
> - <&rpmhcc RPMH_CXO_CLK>,
> + <&tcsr TCSR_PCIE_4L_CLKREF_EN>,
> <&gcc GCC_PCIE_6A_PHY_RCHNG_CLK>,
> - <&gcc GCC_PCIE_6A_PIPE_CLK>;
> + <&gcc GCC_PCIE_6A_PIPE_CLK>,
> + <&gcc GCC_PCIE_6A_PIPEDIV2_CLK>;
> clock-names = "aux",
> "cfg_ahb",
> "ref",
> "rchng",
> - "pipe";
> + "pipe",
> + "pipediv2";
>
> resets = <&gcc GCC_PCIE_6A_PHY_BCR>,
> <&gcc GCC_PCIE_6A_NOCSR_COM_PHY_BCR>;
> @@ -3232,14 +3234,16 @@ pcie4_phy: phy@1c0e000 {
>
> clocks = <&gcc GCC_PCIE_4_AUX_CLK>,
> <&gcc GCC_PCIE_4_CFG_AHB_CLK>,
> - <&rpmhcc RPMH_CXO_CLK>,
> + <&tcsr TCSR_PCIE_2L_4_CLKREF_EN>,
> <&gcc GCC_PCIE_4_PHY_RCHNG_CLK>,
> - <&gcc GCC_PCIE_4_PIPE_CLK>;
> + <&gcc GCC_PCIE_4_PIPE_CLK>,
> + <&gcc GCC_PCIE_4_PIPEDIV2_CLK>;
> clock-names = "aux",
> "cfg_ahb",
> "ref",
> "rchng",
> - "pipe";
> + "pipe",
> + "pipediv2";
>
> resets = <&gcc GCC_PCIE_4_PHY_BCR>;
> reset-names = "phy";
> --
> 2.44.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks
2024-09-16 8:23 ` [PATCH 2/3] arm64: dts: qcom: x1e80100: fix PCIe4 and PCIe6a PHY clocks Johan Hovold
2024-09-16 11:36 ` Abel Vesa
@ 2024-09-16 23:31 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-09-16 23:31 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson, Konrad Dybcio, Vinod Koul
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Conor Dooley,
Abel Vesa, Rajendra Nayak, Sibi Sankar, linux-arm-msm, linux-phy,
devicetree, linux-kernel, stable
On 16.09.2024 10:23 AM, Johan Hovold wrote:
> Add the missing clkref enable and pipediv2 clocks to the PCIe4 and
> PCIe6a PHYs.
>
> Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
> Cc: stable@vger.kernel.org # 6.9
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
I reckon you split it like you day so that it's easier to backport..
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread