* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
[not found] <20241001002900.2628013-1-sashal@kernel.org>
@ 2024-10-01 9:08 ` Dmitry Torokhov
2024-10-01 9:32 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2024-10-01 9:08 UTC (permalink / raw)
To: stable; +Cc: stable-commits, ruanjinjie
On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
>
> Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
>
> to the 5.15-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> and it can be found in the queue-5.15 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
For the love of God, why? Why does this pure cleanup type of change
needs to be in stable?
>
>
>
> commit 2d007ddec282076923c4d84d6b12858b9f44594a
> Author: Jinjie Ruan <ruanjinjie@huawei.com>
> Date: Thu Sep 12 11:30:13 2024 +0800
>
> Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
>
> [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
>
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable when request IRQ.
>
> Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Link: https://lore.kernel.org/r/20240912033013.2610949-1-ruanjinjie@huawei.com
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
> index 8970b49ea09a2..b0238a8b5c210 100644
> --- a/drivers/input/serio/ps2-gpio.c
> +++ b/drivers/input/serio/ps2-gpio.c
> @@ -374,16 +374,14 @@ static int ps2_gpio_probe(struct platform_device *pdev)
> }
>
> error = devm_request_irq(dev, drvdata->irq, ps2_gpio_irq,
> - IRQF_NO_THREAD, DRIVER_NAME, drvdata);
> + IRQF_NO_THREAD | IRQF_NO_AUTOEN, DRIVER_NAME,
> + drvdata);
> if (error) {
> dev_err(dev, "failed to request irq %d: %d\n",
> drvdata->irq, error);
> goto err_free_serio;
> }
>
> - /* Keep irq disabled until serio->open is called. */
> - disable_irq(drvdata->irq);
> -
> serio->id.type = SERIO_8042;
> serio->open = ps2_gpio_open;
> serio->close = ps2_gpio_close;
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
2024-10-01 9:08 ` Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree Dmitry Torokhov
@ 2024-10-01 9:32 ` Greg KH
2024-10-01 10:00 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2024-10-01 9:32 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: stable, stable-commits, ruanjinjie
On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> >
> > to the 5.15-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > and it can be found in the queue-5.15 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
>
> For the love of God, why? Why does this pure cleanup type of change
> needs to be in stable?
Because someone said:
> > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > Date: Thu Sep 12 11:30:13 2024 +0800
> >
> > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> >
> > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> >
> > disable_irq() after request_irq() still has a time gap in which
> > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > disable IRQ auto-enable when request IRQ.
Looks like a bug fix, and also:
> > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
Someone marked it as such.
I'll go drop it, but really, don't mark things as fixes if they really
are not.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
2024-10-01 9:32 ` Greg KH
@ 2024-10-01 10:00 ` Dmitry Torokhov
2024-10-01 10:05 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2024-10-01 10:00 UTC (permalink / raw)
To: Greg KH; +Cc: stable, stable-commits, ruanjinjie
On Tue, Oct 01, 2024 at 11:32:16AM +0200, Greg KH wrote:
> On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> > On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > > This is a note to let you know that I've just added the patch titled
> > >
> > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > >
> > > to the 5.15-stable tree which can be found at:
> > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > The filename of the patch is:
> > > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > > and it can be found in the queue-5.15 subdirectory.
> > >
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> >
> > For the love of God, why? Why does this pure cleanup type of change
> > needs to be in stable?
>
> Because someone said:
>
> > > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > > Date: Thu Sep 12 11:30:13 2024 +0800
> > >
> > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > >
> > > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> > >
> > > disable_irq() after request_irq() still has a time gap in which
> > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > disable IRQ auto-enable when request IRQ.
>
> Looks like a bug fix, and also:
>
> > > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
>
> Someone marked it as such.
>
> I'll go drop it, but really, don't mark things as fixes if they really
> are not.
They are fixes, they just do not belong to stable and that is why they
are not marked as such.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
2024-10-01 10:00 ` Dmitry Torokhov
@ 2024-10-01 10:05 ` Greg KH
2024-10-01 10:47 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2024-10-01 10:05 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: stable, stable-commits, ruanjinjie
On Tue, Oct 01, 2024 at 03:00:05AM -0700, Dmitry Torokhov wrote:
> On Tue, Oct 01, 2024 at 11:32:16AM +0200, Greg KH wrote:
> > On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> > > On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > > > This is a note to let you know that I've just added the patch titled
> > > >
> > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > >
> > > > to the 5.15-stable tree which can be found at:
> > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > >
> > > > The filename of the patch is:
> > > > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > > > and it can be found in the queue-5.15 subdirectory.
> > > >
> > > > If you, or anyone else, feels it should not be added to the stable tree,
> > > > please let <stable@vger.kernel.org> know about it.
> > >
> > > For the love of God, why? Why does this pure cleanup type of change
> > > needs to be in stable?
> >
> > Because someone said:
> >
> > > > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > > > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > > > Date: Thu Sep 12 11:30:13 2024 +0800
> > > >
> > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > >
> > > > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> > > >
> > > > disable_irq() after request_irq() still has a time gap in which
> > > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > > disable IRQ auto-enable when request IRQ.
> >
> > Looks like a bug fix, and also:
> >
> > > > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
> >
> > Someone marked it as such.
> >
> > I'll go drop it, but really, don't mark things as fixes if they really
> > are not.
>
> They are fixes, they just do not belong to stable and that is why they
> are not marked as such.
Ok, if your subsystem will always mark this type of thing properly, we
will be glad to add you to the "don't take any Fixes: only commits" to
the list that we keep. Here's the subsystems that we currently do this
for:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ignore_list
what regex should we use for this list?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
2024-10-01 10:05 ` Greg KH
@ 2024-10-01 10:47 ` Dmitry Torokhov
2024-10-01 11:19 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2024-10-01 10:47 UTC (permalink / raw)
To: Greg KH; +Cc: stable, stable-commits, ruanjinjie
On Tue, Oct 01, 2024 at 12:05:56PM +0200, Greg KH wrote:
> On Tue, Oct 01, 2024 at 03:00:05AM -0700, Dmitry Torokhov wrote:
> > On Tue, Oct 01, 2024 at 11:32:16AM +0200, Greg KH wrote:
> > > On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> > > > On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > > > > This is a note to let you know that I've just added the patch titled
> > > > >
> > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > > >
> > > > > to the 5.15-stable tree which can be found at:
> > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > > >
> > > > > The filename of the patch is:
> > > > > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > > > > and it can be found in the queue-5.15 subdirectory.
> > > > >
> > > > > If you, or anyone else, feels it should not be added to the stable tree,
> > > > > please let <stable@vger.kernel.org> know about it.
> > > >
> > > > For the love of God, why? Why does this pure cleanup type of change
> > > > needs to be in stable?
> > >
> > > Because someone said:
> > >
> > > > > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > > > > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > > > > Date: Thu Sep 12 11:30:13 2024 +0800
> > > > >
> > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > > >
> > > > > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> > > > >
> > > > > disable_irq() after request_irq() still has a time gap in which
> > > > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > > > disable IRQ auto-enable when request IRQ.
> > >
> > > Looks like a bug fix, and also:
> > >
> > > > > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
> > >
> > > Someone marked it as such.
> > >
> > > I'll go drop it, but really, don't mark things as fixes if they really
> > > are not.
> >
> > They are fixes, they just do not belong to stable and that is why they
> > are not marked as such.
>
> Ok, if your subsystem will always mark this type of thing properly, we
> will be glad to add you to the "don't take any Fixes: only commits" to
> the list that we keep. Here's the subsystems that we currently do this
> for:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ignore_list
>
> what regex should we use for this list?
Let's do:
drivers/input/*
and see how it goes.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree
2024-10-01 10:47 ` Dmitry Torokhov
@ 2024-10-01 11:19 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2024-10-01 11:19 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: stable, stable-commits, ruanjinjie
On Tue, Oct 01, 2024 at 03:47:00AM -0700, Dmitry Torokhov wrote:
> On Tue, Oct 01, 2024 at 12:05:56PM +0200, Greg KH wrote:
> > On Tue, Oct 01, 2024 at 03:00:05AM -0700, Dmitry Torokhov wrote:
> > > On Tue, Oct 01, 2024 at 11:32:16AM +0200, Greg KH wrote:
> > > > On Tue, Oct 01, 2024 at 02:08:42AM -0700, Dmitry Torokhov wrote:
> > > > > On Mon, Sep 30, 2024 at 08:28:59PM -0400, Sasha Levin wrote:
> > > > > > This is a note to let you know that I've just added the patch titled
> > > > > >
> > > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > > > >
> > > > > > to the 5.15-stable tree which can be found at:
> > > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > > > >
> > > > > > The filename of the patch is:
> > > > > > input-ps2-gpio-use-irqf_no_autoen-flag-in-request_ir.patch
> > > > > > and it can be found in the queue-5.15 subdirectory.
> > > > > >
> > > > > > If you, or anyone else, feels it should not be added to the stable tree,
> > > > > > please let <stable@vger.kernel.org> know about it.
> > > > >
> > > > > For the love of God, why? Why does this pure cleanup type of change
> > > > > needs to be in stable?
> > > >
> > > > Because someone said:
> > > >
> > > > > > commit 2d007ddec282076923c4d84d6b12858b9f44594a
> > > > > > Author: Jinjie Ruan <ruanjinjie@huawei.com>
> > > > > > Date: Thu Sep 12 11:30:13 2024 +0800
> > > > > >
> > > > > > Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()
> > > > > >
> > > > > > [ Upstream commit dcd18a3fb1228409dfc24373c5c6868a655810b0 ]
> > > > > >
> > > > > > disable_irq() after request_irq() still has a time gap in which
> > > > > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > > > > disable IRQ auto-enable when request IRQ.
> > > >
> > > > Looks like a bug fix, and also:
> > > >
> > > > > > Fixes: 9ee0a0558819 ("Input: PS/2 gpio bit banging driver for serio bus")
> > > >
> > > > Someone marked it as such.
> > > >
> > > > I'll go drop it, but really, don't mark things as fixes if they really
> > > > are not.
> > >
> > > They are fixes, they just do not belong to stable and that is why they
> > > are not marked as such.
> >
> > Ok, if your subsystem will always mark this type of thing properly, we
> > will be glad to add you to the "don't take any Fixes: only commits" to
> > the list that we keep. Here's the subsystems that we currently do this
> > for:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ignore_list
> >
> > what regex should we use for this list?
>
> Let's do:
>
> drivers/input/*
>
> and see how it goes.
Ok, now added, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-01 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241001002900.2628013-1-sashal@kernel.org>
2024-10-01 9:08 ` Patch "Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()" has been added to the 5.15-stable tree Dmitry Torokhov
2024-10-01 9:32 ` Greg KH
2024-10-01 10:00 ` Dmitry Torokhov
2024-10-01 10:05 ` Greg KH
2024-10-01 10:47 ` Dmitry Torokhov
2024-10-01 11:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox