From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
stable-commits@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: Patch "selftests: vDSO: skip getrandom test if architecture is unsupported" has been added to the 6.11-stable tree
Date: Wed, 2 Oct 2024 06:13:45 +0200 [thread overview]
Message-ID: <ZvzIeenvKYaG_B1y@zx2c4.com> (raw)
In-Reply-To: <2db8ba9e-853c-4733-be39-4b4207da2367@linuxfoundation.org>
On Tue, Oct 01, 2024 at 09:29:45AM -0600, Shuah Khan wrote:
> On 10/1/24 09:03, Jason A. Donenfeld wrote:
> > On Tue, Oct 01, 2024 at 08:56:43AM -0600, Shuah Khan wrote:
> >> On 10/1/24 08:45, Jason A. Donenfeld wrote:
> >>> On Tue, Oct 01, 2024 at 08:43:05AM -0600, Shuah Khan wrote:
> >>>> On 9/30/24 21:56, Jason A. Donenfeld wrote:
> >>>>> This is not stable material and I didn't mark it as such. Do not backport.
> >>>>
> >>>> The way selftest work is they just skip if a feature isn't supported.
> >>>> As such this test should run gracefully on stable releases.
> >>>>
> >>>> I would say backport unless and skip if the feature isn't supported.
> >>>
> >>> Nonsense. 6.11 never returns ENOSYS from vDSO. This doesn't make sense.
> >>
> >> Not sure what you mean by Nonsense. ENOSYS can be used to skip??
> >
> > The branch that this patch adds will never be reached in 6.11 because
> > the kernel does not have the corresponding code.
>
> What should/would happen if this test is run on a kernel that doesn't
> support the feature?
The build system doesn't compile it for kernels without the feature.
next prev parent reply other threads:[~2024-10-02 4:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240930231443.2560728-1-sashal@kernel.org>
2024-10-01 3:56 ` Patch "selftests: vDSO: skip getrandom test if architecture is unsupported" has been added to the 6.11-stable tree Jason A. Donenfeld
2024-10-01 14:43 ` Shuah Khan
2024-10-01 14:45 ` Jason A. Donenfeld
2024-10-01 14:56 ` Shuah Khan
2024-10-01 15:03 ` Jason A. Donenfeld
2024-10-01 15:29 ` Shuah Khan
2024-10-02 4:13 ` Jason A. Donenfeld [this message]
2024-10-02 6:21 ` Greg KH
2024-10-02 17:00 ` Jason A. Donenfeld
2024-10-02 19:45 ` Shuah Khan
2024-10-02 21:01 ` Jason A. Donenfeld
2024-10-03 16:53 ` Shuah Khan
2024-10-03 16:58 ` Jason A. Donenfeld
2024-10-03 17:22 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvzIeenvKYaG_B1y@zx2c4.com \
--to=jason@zx2c4.com \
--cc=sashal@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox