From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92F916FF2A; Tue, 8 Oct 2024 11:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728385468; cv=none; b=BjwkAxzixzU5t0uBE26jTrI/9F7Hs+vPJUlX0Id3Rae7miF0nfzeTFl6YH0zzlLA/hBJKtrLEdqOn3cXhVeyV1aWe7smDB0N8BweSX1kpJSETb36GuDLDS7oz2VUdFY93Uslfd+5DiR3xmBBjU2B7GACtMq1/us/8eDc77cyr88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728385468; c=relaxed/simple; bh=d+4dJ9Ma+xa5ecnFCjCiJyEy9xn4w2t7xy9bBhkJBio=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yrtz0REtnjnbiPdBZhniB0tM5fc9Hs4AEOHgM/Obd1QWT1aGfD8B65ILXpc7B8EE6oOCAqMZ9dfo9JihqYuSGzkLEXsMLlwjey/B6lZ53qCzlnftElYnfUgTAyv9A2lUS4zKx4SoVZB7C4rsGe2xY/SGRlIlZfCltrEeVt7HunY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TurhgPjT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TurhgPjT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9189C4CEC7; Tue, 8 Oct 2024 11:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728385468; bh=d+4dJ9Ma+xa5ecnFCjCiJyEy9xn4w2t7xy9bBhkJBio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TurhgPjTQ805yeA/y+pp7tgQYJlBpGFff7h5LXnlXArSqG+a+guCmzvRbe+3YrLFN 15A/dAsNTnDcDE4tSJdb9KbjpMXcnLmhTRCEVlZy6iTbefcEAcSEjQfBMyfDiO+0Dw ++pfrqcWg/yMLA4iqwA2SFACfZXkL1lo5cNhU8AfF1M8t7hplKhV5f7Eyrj0LJ++cA nQ4m5y3EK3ODlI3ciDppp0YWFI+xUG3v3dNhdGv19PKfFygBF4jqodwi0wEcbUGpKT ylECF+7xN2JsmEl6oHW5Ko+7BWMCPFUz/4knKYUYJC/CE0cwsu6LJ4c8DJMqP7YiSA iLdLRZL3QGKYg== Date: Tue, 8 Oct 2024 13:04:22 +0200 From: Danilo Krummrich To: Yonatan Maman Cc: kherbst@redhat.com, lyude@redhat.com, dakr@redhat.com, airlied@gmail.com, daniel@ffwll.ch, bskeggs@nvidia.com, jglisse@redhat.com, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Gal Shalom Subject: Re: [PATCH v3 1/2] nouveau/dmem: Fix privileged error in copy engine channel Message-ID: References: <20241008073103.987926-1-ymaman@nvidia.com> <20241008073103.987926-2-ymaman@nvidia.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241008073103.987926-2-ymaman@nvidia.com> On Tue, Oct 08, 2024 at 10:31:02AM +0300, Yonatan Maman wrote: > From: Yonatan Maman > > When `nouveau_dmem_copy_one` is called, the following error occurs: > > [272146.675156] nouveau 0000:06:00.0: fifo: PBDMA9: 00000004 [HCE_PRIV] > ch 1 00000300 00003386 > > This indicates that a copy push command triggered a Host Copy Engine > Privileged error on channel 1 (Copy Engine channel). To address this > issue, modify the Copy Engine channel to allow privileged push commands > > Fixes: 6de125383a5c ("drm/nouveau/fifo: expose runlist topology info on all chipsets") > Signed-off-by: Yonatan Maman > Signed-off-by: Gal Shalom > Co-developed-by: Gal Shalom 'Co-developed-by' must be immediately followed by the corresponding 'Signed-off-by'. This is just a nit, but it indicates you didn't run ./scripts/checkpatch.pl, did you? > Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c > index a58c31089613..0a75ce4c5021 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -356,7 +356,7 @@ nouveau_accel_ce_init(struct nouveau_drm *drm) > return; > } > > - ret = nouveau_channel_new(drm, device, false, runm, NvDmaFB, NvDmaTT, &drm->cechan); > + ret = nouveau_channel_new(drm, device, true, runm, NvDmaFB, NvDmaTT, &drm->cechan); This patch does not apply, it seems like it is based on some old or OOT version of the code. Please make sure to rebase and test your patches against upstream code if you're submitting patches upstream. > if (ret) > NV_ERROR(drm, "failed to create ce channel, %d\n", ret); > } > -- > 2.34.1 >