From: Danilo Krummrich <dakr@kernel.org>
To: Yonatan Maman <ymaman@nvidia.com>
Cc: kherbst@redhat.com, lyude@redhat.com, dakr@redhat.com,
airlied@gmail.com, daniel@ffwll.ch, bskeggs@nvidia.com,
jglisse@redhat.com, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v4 0/2] drm/nouveau/dmem: Fix Vulnerability and Device Channels configuration
Date: Tue, 8 Oct 2024 14:28:33 +0200 [thread overview]
Message-ID: <ZwUlcWka1_CgXRyG@cassiopeiae> (raw)
In-Reply-To: <20241008115943.990286-1-ymaman@nvidia.com>
On Tue, Oct 08, 2024 at 02:59:41PM +0300, Yonatan Maman wrote:
> From: Yonatan Maman <Ymaman@Nvidia.com>
>
> This patch series addresses two critical issues in the Nouveau driver
> related to device channels, error handling, and sensitive data leaks.
>
> - Vulnerability in migrate_to_ram: The migrate_to_ram function might
> return a dirty HIGH_USER page when a copy push command (FW channel)
> fails, potentially exposing sensitive data and posing a security
> risk. To mitigate this, the patch ensures the allocation of a non-dirty
> (zero) page for the destination, preventing the return of a dirty page
> and enhancing driver security in case of failure.
>
> - Privileged Error in Copy Engine Channel: An error was observed when
> the nouveau_dmem_copy_one function is executed, leading to a Host Copy
> Engine Privileged error on channel 1. The patch resolves this by
> adjusting the Copy Engine channel configuration to permit privileged
> push commands, resolving the error.
>
> Changes since V3:
> - Fixed version according to Danilo Krummrich's comments.
>
> Yonatan Maman (2):
> nouveau/dmem: Fix privileged error in copy engine channel
> nouveau/dmem: Fix vulnerability in migrate_to_ram upon copy error
Applied to drm-misc-fixes, thanks!
prev parent reply other threads:[~2024-10-08 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 11:59 [PATCH v4 0/2] drm/nouveau/dmem: Fix Vulnerability and Device Channels configuration Yonatan Maman
2024-10-08 11:59 ` [PATCH v4 1/2] nouveau/dmem: Fix privileged error in copy engine channel Yonatan Maman
2024-10-08 12:02 ` kernel test robot
2024-10-08 11:59 ` [PATCH v4 2/2] nouveau/dmem: Fix vulnerability in migrate_to_ram upon copy error Yonatan Maman
2024-10-08 12:28 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwUlcWka1_CgXRyG@cassiopeiae \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=bskeggs@nvidia.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ymaman@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox