From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
W <linuxcdeveloper@gmail.com>,
stable@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: libata: avoid superfluous disk spin down + spin up during hibernation
Date: Wed, 9 Oct 2024 16:18:48 +0200 [thread overview]
Message-ID: <ZwaQyGkeRNNgLwef@x1-carbon.lan> (raw)
In-Reply-To: <5bd13541-4ac0-4171-b4e5-0dedaa9e88b5@kernel.org>
On Wed, Oct 09, 2024 at 07:44:31PM +0900, Damien Le Moal wrote:
> On 10/8/24 22:58, Niklas Cassel wrote:
> > A user reported that commit aa3998dbeb3a ("ata: libata-scsi: Disable scsi
> > device manage_system_start_stop") introduced a spin down + immediate spin
> > up of the disk both when entering and when resuming from hibernation.
> > This behavior was not there before, and causes an increased latency both
> > when when entering and when resuming from hibernation.
>
> One too many "when".
Will fix up when applying.
> With the above nit fixed,
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Thanks!
next prev parent reply other threads:[~2024-10-09 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 13:58 [PATCH v2] ata: libata: avoid superfluous disk spin down + spin up during hibernation Niklas Cassel
2024-10-09 10:44 ` Damien Le Moal
2024-10-09 14:18 ` Niklas Cassel [this message]
2024-10-09 14:26 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwaQyGkeRNNgLwef@x1-carbon.lan \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linuxcdeveloper@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox