From: Sasha Levin <sashal@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sherry Yang <sherry.yang@oracle.com>,
stable@vger.kernel.org, jeyu@kernel.org, rostedt@goodmis.org,
mingo@redhat.com, ast@kernel.org, jolsa@kernel.org,
mhiramat@kernel.org, flaniel@linux.microsoft.com
Subject: Re: [PATCH 5.10.y 0/4] Backport fix commit for kprobe_non_uniq_symbol.tc test failure
Date: Wed, 9 Oct 2024 12:21:45 -0400 [thread overview]
Message-ID: <ZwatmQ2V8xxf1dyE@sashalap> (raw)
In-Reply-To: <2024100909-neatness-kennel-c24d@gregkh>
On Wed, Oct 09, 2024 at 03:36:42PM +0200, Greg KH wrote:
>On Tue, Oct 08, 2024 at 03:29:44PM -0700, Sherry Yang wrote:
>> 5.10.y backported the commit
>> 09bcf9254838 ("selftests/ftrace: Add new test case which checks non unique symbol")
>> which added a new test case to check non-unique symbol. However, 5.10.y
>> didn't backport the kernel commit
>> b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols")to support the functionality from kernel side. Backport it in this patch series.
>>
>> The first two patches are presiquisites. The 4th commit is a fix commit
>> for the 3rd one.
>
>Should we just revert the selftest test instead? That seems simpler
>instead of adding a new feature to this old and obsolete kernel tree,
>right?
Greg, I read the cover letter the same way and asked myself the same
question, but looking at the patches it's actually a fix for something
that's broken on 5.10 and was just uncovered by the selftest.
I think we should take it.
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-10-09 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 22:29 [PATCH 5.10.y 0/4] Backport fix commit for kprobe_non_uniq_symbol.tc test failure Sherry Yang
2024-10-08 22:29 ` [PATCH 5.10.y 1/4] kallsyms: Make kallsyms_on_each_symbol generally available Sherry Yang
2024-10-08 22:29 ` [PATCH 5.10.y 2/4] kallsyms: Make module_kallsyms_on_each_symbol " Sherry Yang
2024-10-08 22:29 ` [PATCH 5.10.y 3/4] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Sherry Yang
2024-10-08 22:29 ` [PATCH 5.10.y 4/4] tracing/kprobes: Fix symbol counting logic by looking at modules as well Sherry Yang
2024-10-09 13:36 ` [PATCH 5.10.y 0/4] Backport fix commit for kprobe_non_uniq_symbol.tc test failure Greg KH
2024-10-09 14:44 ` Steven Rostedt
2024-10-09 16:21 ` Sasha Levin [this message]
2024-10-10 16:11 ` Sherry Yang
2024-10-11 11:30 ` Francis Laniel
2024-10-11 12:13 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwatmQ2V8xxf1dyE@sashalap \
--to=sashal@kernel.org \
--cc=ast@kernel.org \
--cc=flaniel@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sherry.yang@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox