From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966F01DB37A for ; Fri, 18 Oct 2024 13:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729259586; cv=none; b=m7UMdVg5XtbxvjSarcGn3/0AZQ/9pvCE9i3gNbvkwKojFwdj8XT+4ioG2HzBW5T1GycWiyhn7LI8Ny7PP6vw/UCZto+GQvJ8MevPNHvleZUtiMgO15PX/37mA5I5GbX1pAgHPdZIkKDeWVoFkuAEeMvlGxP7LQlygV8w4wQCAX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729259586; c=relaxed/simple; bh=+pUqJ3djmbey5TSUtiG526xMXDdGeCWo+FHB78sE/JI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i7RCIzcz+cR+EJof1eKQyJgwePi0jnYLmbQp/dipbXxY4PzdCDG/r8S5H4Gs1ViPswu/b/EZMIuLOc0+hYRD86MUWdvdj955QqXMfV8Dh8mLzeEgP5waYZtp8vQaG2caZ8s60SB6a5Lotm5xXaJoJIoj3pn1lMTCUraxFcsbP5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CxPWUIo7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CxPWUIo7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729259583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3MdTWV2aPXX7qYLVHT7xAeOS8FRxLhj6WL39+1SSrXE=; b=CxPWUIo7+1h1K/xyOabbQiDPYn4CUQK8kWlBhHPToSip0CsPu2IC+KsbSk6jh14pN7ogFz D+gnfOqERRucD/NCZ9xqcH0FfFrjHEJO8mjHkb/4sbDwo0gXJ+EPk8MDm98kOF3+kKTwKO 2ZUxQUe/Ts3w9f8w9bkyZzelwBvfADQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-vkadPesGPGSnk3vtBPuUeg-1; Fri, 18 Oct 2024 09:52:58 -0400 X-MC-Unique: vkadPesGPGSnk3vtBPuUeg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E918319560B8; Fri, 18 Oct 2024 13:52:54 +0000 (UTC) Received: from localhost (unknown [10.72.112.28]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7518A1955E94; Fri, 18 Oct 2024 13:52:51 +0000 (UTC) Date: Fri, 18 Oct 2024 21:52:47 +0800 From: Baoquan He To: Andy Shevchenko Cc: Gregory Price , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, bhelgaas@google.com, ilpo.jarvinen@linux.intel.com, mika.westerberg@linux.intel.com, ying.huang@intel.com, tglx@linutronix.de, takahiro.akashi@linaro.org, stable@vger.kernel.org Subject: Re: [PATCH] resource,kexec: walk_system_ram_res_rev must retain resource flags Message-ID: References: <20241017190347.5578-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 10/18/24 at 03:22pm, Andy Shevchenko wrote: > On Fri, Oct 18, 2024 at 10:18:42AM +0800, Baoquan He wrote: > > HI Gregory, > > > > On 10/17/24 at 03:03pm, Gregory Price wrote: > > > walk_system_ram_res_rev() erroneously discards resource flags when > > > passing the information to the callback. > > > > > > This causes systems with IORESOURCE_SYSRAM_DRIVER_MANAGED memory to > > > have these resources selected during kexec to store kexec buffers > > > if that memory happens to be at placed above normal system ram. > > > > Sorry about that. I haven't checked IORESOURCE_SYSRAM_DRIVER_MANAGED > > memory carefully, wondering if res could be set as > > 'IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY' plus > > IORESOURCE_SYSRAM_DRIVER_MANAGED in iomem_resource tree. > > > > Anyway, the change in this patch is certainly better. Thanks. > > Can we get more test cases in the respective module, please? Do you mean testing CXL memory in kexec/kdump? No, we can't. Kexec/kdump test cases basically is system testing, not unit test or module test. It needs run system and then jump to 2nd kernel, vm can be used but it can't cover many cases existing only on baremetal. Currenly, Redhat's CKI is heavily relied on to test them, however I am not sure if system with CXL support is available in our LAB. Not sure if I got you right.