From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from submarine.notk.org (submarine.notk.org [62.210.214.84]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F8A21F94A for ; Sat, 2 Nov 2024 07:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.210.214.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730530969; cv=none; b=AM9q8pEYzX7wAViE/F9PgxCK8obYuv2tNokxyHYR+V+MFeW88k0V1mM92qKCguNMO0g53lHonpY3xR4LvcM/81x7nLtQNFJZpm7Pux36G0tAtdcNfo7IzKIZ2nhOzj8rDA8reODLzHaUf2/D4RF4IrHKGzFWZOSoi3safUesfjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730530969; c=relaxed/simple; bh=6qgIP8JEmjmucwFT9AXCLyUvK1DRDTiN4RH2aRExwxA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ELlPvPq6cNrUVy3C7AakOXqJphGZkuVVxR5h/7fnfX//W95z+sW6/Eg8aCtrRFID8HvK7+Wy11xJJk1AbP248hlMsqwRpN9UjPsWh4VqdjJp7CTYxyS8IpKQSd0JQE4oxhx7Zf7QLx72x/YoEborGhvir1iBOi9/LP4lxnie+N4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codewreck.org; spf=pass smtp.mailfrom=codewreck.org; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b=Rqv7k7GC; arc=none smtp.client-ip=62.210.214.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codewreck.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codewreck.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="Rqv7k7GC" Received: from gaia.codewreck.org (localhost [127.0.0.1]) by submarine.notk.org (Postfix) with ESMTPS id DD3F614C1E1; Sat, 2 Nov 2024 08:02:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1730530965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wMxrZV+pjZ0+aq2vXiiJbHJNjQKrDjvPSdgBmRqBGtw=; b=Rqv7k7GCE/0AUTQ8ZwBt/DQ8V/gWrrGeddyFdzcthYOUcJqyGybc6J1Fchz3iaChl0ejh0 rj+mUJByLa7cLec83M6dTbnz54H7cBRH6vYH5z6jVK57qVj63254Vuxg/lSCRAEaKszZdb ycCgRWxIHggYU6/BpHwsZnTcuQEjPOc33fPcvhphHfiFdi1Hknon4W8nUAYDv6Nvu0FnHR gJpBOiXkcRk9u6O5lEXR2fW+tSyfSCxFLG4zUmhPhxdwFiZPJUqRppzZe/qYc2faZvYOUN sa/SZ5Dc2tQ4+k+xTtpY0HdYORGb0Gk9FRCsiN8yxJocK9oWgLP2diFGpE+ayQ== Received: from localhost (gaia.codewreck.org [local]) by gaia.codewreck.org (OpenSMTPD) with ESMTPA id 1a7914d1; Sat, 2 Nov 2024 07:02:42 +0000 (UTC) Date: Sat, 2 Nov 2024 16:02:27 +0900 From: Dominique Martinet To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, Chuck Lever , Christian Brauner , NeilBrown , Jeff Layton Subject: Re: [PATCH 6.6] SUNRPC: Remove BUG_ON call sites Message-ID: References: <20241102065203.13291-1-asmadeus@codewreck.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241102065203.13291-1-asmadeus@codewreck.org> Dominique Martinet wrote on Sat, Nov 02, 2024 at 03:52:03PM +0900: > From: Chuck Lever > > [ Upstream commit 789ce196a31dd13276076762204bee87df893e53 ] > > There is no need to take down the whole system for these assertions. > > I'd rather not attempt a heroic save here, as some bug has occurred > that has left the transport data structures in an unknown state. > Just warn and then leak the left-over resources. > > Acked-by: Christian Brauner > Reviewed-by: NeilBrown > Reviewed-by: Jeff Layton > Signed-off-by: Chuck Lever grmbl, missing my signed-off, sorry: Signed-off-by: Dominique Martinet hopefully didn't miss anything else.. -- Dominique