From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE983157A6B for ; Sat, 2 Nov 2024 22:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730586387; cv=none; b=FkPS8s6TCRveQKupSNFYrifT7pu5Puc6d6M8+h9hjw2sk92ticnFaXiD8mbjRjw+4zpCqvBoBNCjGYe1f7MKjiJBDF2rTjHW/rfnvnWv5WvI0tqMF3gm2zVZ2lnaHb/PqMt7MEOU4t1hmKVgE5IVyOOWQSfmP647uF3yTT9NoNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730586387; c=relaxed/simple; bh=nAQxc/PidVP50ELM/jHfGS68cE7nwN57aN0v/4rM31c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XuDOknS2ZPdvsIqvLiHy5PCUp3EHk8TG2lWEKO78AkigwaAJsznzXJ4XRT5XTsEFwlrJpG2QYjhpZHuRwzYwQ3Tta9iYYFxVmKqHvIpoWOanXMUeXX/YZKAO+dQaxsWmEllRFNntwO7I2W4cQxyhbvkwgfPcmjKecH4WjRTcXAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MUzFYvjT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MUzFYvjT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CFFDC4CEC3; Sat, 2 Nov 2024 22:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730586387; bh=nAQxc/PidVP50ELM/jHfGS68cE7nwN57aN0v/4rM31c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MUzFYvjTzpX7AA+kuGc+qiB/GwE5bbhjxmkczT4whemtGNTpfmvgbtWRolVeRr8eL ao3Ch59Ga/rAGiaZoPL/pkcxXUQ33dAxYi1/20yak0xpTFtJHIHiq/WYc+3ywpHC2j /SUh2j+PFuV0acy93QY0RmErl0HLtnrqhSNOJJOOGa3eTFBAdgqYSMrd/oRO7GBFfp UhnrfA2S8uUBiHrHo83/rk/Ufl2UMwtKon17b67ttMC/FuBvZ/eJ38WpHFTt4PpaTJ iEC6RnSmPa84BuNJmNAyri4iOjpG93pr569uXKq2IBYs9O5xhV+sak2DiDgNDQwO/8 fEPqXhJtKK5nw== Date: Sat, 2 Nov 2024 18:26:25 -0400 From: Sasha Levin To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Greg Kroah-Hartman , Steve French , Paulo Alcantara , stable@vger.kernel.org Subject: Re: Backport smb client char/block fixes Message-ID: References: <20241028094339.zrywdlzguj6udyg7@pali> <20241101235645.yqwqqipzhzoyprch@pali> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241101235645.yqwqqipzhzoyprch@pali> On Sat, Nov 02, 2024 at 12:56:45AM +0100, Pali Rohár wrote: >Hello Greg and Sasha, do you have any opinion about this? > >On Monday 28 October 2024 10:43:39 Pali Rohár wrote: >> Hello, >> >> I would like to propose backporting these two commits into stable: >> * 663f295e3559 ("smb: client: fix parsing of device numbers") >> * a9de67336a4a ("smb: client: set correct device number on nfs reparse points") >> >> Linux SMB client without these two recent fixes swaps device major and >> minor numbers, which makes basically char/block device nodes unusable. >> >> Commit 663f295e3559 ("smb: client: fix parsing of device numbers") >> should have had following Fixes line: >> Fixes: 45e724022e27 ("smb: client: set correct file type from NFS reparse points") >> >> And commit a9de67336a4a ("smb: client: set correct device number on nfs >> reparse points") should have contained line: >> Fixes: 102466f303ff ("smb: client: allow creating special files via reparse points") >> >> Pali I'll queue both for 6.11 and 6.6, thanks! -- Thanks, Sasha