From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19CC51C729B for ; Mon, 4 Nov 2024 18:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730744486; cv=none; b=JqFFCJONdMSQ8HATaDIpEJBEDEMeWVU7naswmLx3ba7UIKVK3TIsgrU+egpPuK5mgV+h5haLh4TfgaQfa9dx4CzqOIMsGwilHcMrlWU1jYvegFl3q6hG4TSBrHq6cTNJpOlUYoU8ySw1Bh/2ysyYJdJF5SO0ssPRSzIZm2tqrZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730744486; c=relaxed/simple; bh=psda6WZ1bBDxqXSARndeShzdtueMUbDrCIxmrU6wCE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CHXy8Kak98Q55EVIrfot8eDWbUle93rFPzKX4zJRihgt4kj9tejBhq0Q9gZMosrlo5tLLyQin6VW8PMOmFxL0bG4bOm5/IDhgMHcBdgIu10fcsU0ujwSoyxMw+gwobLFLPcXtevOpZeWZjZEEqhjaQsiuP6/vquIZG8bYannQ/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JTPx3l1d; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JTPx3l1d" Date: Mon, 4 Nov 2024 18:21:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730744482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fRQZ1b4+YzN47zBQE0OhZW60GzonoSgG9kJ9tuC58Z0=; b=JTPx3l1d7ph/0YpLYRHb25UqZvpCwpxyzKx8JW6t5Jcpn2hrGkRinjAZkObAsDENFP/XqG SJiZ4OTf9raPwg1llQeWxlb7AArJ+obj4/o/ba7F2pTnRArw0p+oybu/CIIX0VFGqfxzfk Zg38nTaWMmO88Fi0j7emw8wM1U1zsjg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Oleg Nesterov Cc: Alexey Gladkov , Andrei Vagin , "Eric W. Biederman" , linux-kernel@vger.kernel.org, Kees Cook , stable@vger.kernel.org Subject: Re: [PATCH] signal: restore the override_rlimit logic Message-ID: References: <20241031200438.2951287-1-roman.gushchin@linux.dev> <87zfmi3f8b.fsf@email.froward.int.ebiederm.org> <87o72y3c4g.fsf@email.froward.int.ebiederm.org> <20241103165048.GA11668@redhat.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241103165048.GA11668@redhat.com> X-Migadu-Flow: FLOW_OUT On Sun, Nov 03, 2024 at 05:50:49PM +0100, Oleg Nesterov wrote: > On 11/02, Alexey Gladkov wrote: > > > > +Cc Oleg Nesterov. > > Well, I tend to agree with Roman and his patch looks good to me. Thanks, Oleg! > > But it seems that the change in inc_rlimit_get_ucounts() can be > a bit simpler and more readable, see below. Eric suggested the same approach earlier in this thread. I personally don't have a strong preference here or actually I slightly prefer my own version because this comparison to LONG_MAX looks confusing to me. But if you have a strong preference, I'm happy to send out v2. Please, let me know. Thanks!