From: Alexey Gladkov <legion@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>,
Andrei Vagin <avagin@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] signal: restore the override_rlimit logic
Date: Mon, 4 Nov 2024 20:02:35 +0100 [thread overview]
Message-ID: <ZykaS1arGZ3DMFkm@example.org> (raw)
In-Reply-To: <20241104184442.GA26235@redhat.com>
On Mon, Nov 04, 2024 at 07:44:43PM +0100, Oleg Nesterov wrote:
> On 11/04, Roman Gushchin wrote:
> >
> > On Sun, Nov 03, 2024 at 05:50:49PM +0100, Oleg Nesterov wrote:
> > >
> > > But it seems that the change in inc_rlimit_get_ucounts() can be
> > > a bit simpler and more readable, see below.
> >
> > Eric suggested the same approach earlier in this thread.
>
> Ah, good, I didn't know ;)
>
> > I personally
> > don't have a strong preference here or actually I slightly prefer my
> > own version because this comparison to LONG_MAX looks confusing to me.
> > But if you have a strong preference, I'm happy to send out v2. Please,
> > let me know.
>
> Well, I won't insist.
>
> To me the change proposed by Eric and me looks much more readable, but
> of course this is subjective.
>
> But you know, you can safely ignore me. Alexey and Eric understand this
> code much better, so I leave this to you/Alexey/Eric.
Personally, I like Oleg's patch more.
--
Rgrds, legion
next prev parent reply other threads:[~2024-11-04 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 20:04 [PATCH] signal: restore the override_rlimit logic Roman Gushchin
2024-11-01 19:51 ` Eric W. Biederman
2024-11-01 20:38 ` Roman Gushchin
2024-11-01 20:58 ` Eric W. Biederman
2024-11-01 21:21 ` Roman Gushchin
2024-11-01 22:44 ` Andrei Vagin
2024-11-02 16:26 ` Alexey Gladkov
2024-11-03 16:50 ` Oleg Nesterov
2024-11-04 18:21 ` Roman Gushchin
2024-11-04 18:44 ` Oleg Nesterov
2024-11-04 19:02 ` Alexey Gladkov [this message]
2024-11-04 19:42 ` Roman Gushchin
2024-11-01 23:28 ` Alexey Gladkov
2024-11-01 23:50 ` Roman Gushchin
2024-11-02 13:46 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZykaS1arGZ3DMFkm@example.org \
--to=legion@kernel.org \
--cc=avagin@google.com \
--cc=ebiederm@xmission.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).