From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE563A873D for ; Fri, 26 Jun 2026 14:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782482738; cv=none; b=NgTDF4d0IjJeXZieJHj1jxxH/VNQSkQ/DKgua39mh7zX5oi7q+anB81u6ZsgbRSMfi2nSdAXvxEx27Um7ybTlnegNGOVS7PShg5zfBxHbob2V4jmNXvqwYUkMOKpoqKkQxA45xLfTjtXnXxS2LP7jNcEQAQuKLG4rzBkvd0AZDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782482738; c=relaxed/simple; bh=gGeatAbNW1Tyu504ZrnFfEPUli8yfMeLx+6zsAYFJ9U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=b0vbaIXqBMfFabkLe1Ujo3RFOPERFwZ+BXPcSMTV4lTXL+43P4TnZPbL6sIY5jSF8dsoCul5kcJos8Cp5UBY/sPNbCgqI5EoJ3lWIWUoviRtNf8lvzSX+zogVJ47V3p2Xzfh3Ns0m11uUGEmbLPnKoGgJfRAGK3N8XCunqG38fM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WfPPpFF9; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WfPPpFF9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782482735; x=1814018735; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=gGeatAbNW1Tyu504ZrnFfEPUli8yfMeLx+6zsAYFJ9U=; b=WfPPpFF9baFKqJ9OIghoIJMTqMH+NulkU/Ht2S7frlIhs3M8igyr94aS Oph7v1Frt4ppi5DTiE+3KT2gNZa66zsq1rAzfQ06mOtb9ej9D1B0Nuy2F ODH2k3gISJL8LPEBuMorHMsGYKsRP6Op9LdHNjL1jivF22hK0Lg6sIwr/ gDeNEnqftTSyD8Tc0NBop+plVCSkfAFZF9nwLGH29GBAK8ehF1ZnY445D 4u1BE1aipVPTeTGlXLhR7PE7v2cBRqJRI0/ntxbTuPlJ3E00ycFW5NAWq dM7CD0oclGyNVfKchktwId3+nyYOd0hIiHlYcw3tHovsf531Lvtbp9Ztx g==; X-CSE-ConnectionGUID: mGa65Ac1SmiCHcf+Q7kOJw== X-CSE-MsgGUID: uAvRgGDSSLGytPaUoXAteQ== X-IronPort-AV: E=McAfee;i="6800,10657,11829"; a="83283954" X-IronPort-AV: E=Sophos;i="6.24,226,1774335600"; d="scan'208";a="83283954" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2026 07:05:34 -0700 X-CSE-ConnectionGUID: e20pPGzvQx+yPzexCcSK7w== X-CSE-MsgGUID: exshc02NS/ypqar2jMHPtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,226,1774335600"; d="scan'208";a="289431826" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.22]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2026 07:05:32 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Martin Hodo , stable@vger.kernel.org, Ankit Nautiyal Subject: Re: [PATCH] drm/i915/vrr: require valid min/max vfreq for VRR In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260625131040.1051272-1-jani.nikula@intel.com> Date: Fri, 26 Jun 2026 17:05:28 +0300 Message-ID: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 26 Jun 2026, Ville Syrj=C3=A4l=C3=A4 wrote: > On Thu, Jun 25, 2026 at 04:10:40PM +0300, Jani Nikula wrote: >> Ensure the EDID provided min/max vfreq are valid. Most scenarios are >> already covered (by coincidence) through the checks in >> intel_vrr_is_capable() and intel_vrr_is_in_range(), but be more explicit >> about it. At worst, a zero min_vfreq could lead to a division by zero in >> intel_vrr_compute_vmax(). >>=20 >> Discovered using AI-assisted static analysis confirmed by Intel Product >> Security. >>=20 >> Reported-by: Martin Hodo >> Fixes: 117cd09ba528 ("drm/i915/display/dp: Compute VRR state in atomic_c= heck") >> Cc: # v5.12+ >> Cc: Ankit Nautiyal >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/display/intel_vrr.c | 4 ++++ >> 1 file changed, 4 insertions(+) >>=20 >> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/= i915/display/intel_vrr.c >> index 5d9b11185296..bffbdee76ee1 100644 >> --- a/drivers/gpu/drm/i915/display/intel_vrr.c >> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c >> @@ -76,6 +76,10 @@ bool intel_vrr_is_capable(struct intel_connector *con= nector) >> return false; >> } >>=20=20 >> + if (!info->monitor_range.min_vfreq || !info->monitor_range.max_vfreq || >> + info->monitor_range.min_vfreq > info->monitor_range.max_vfreq) >> + return false; > > Perhaps it should be the responsibility of the EDID parser to make sure > the range isn't completely insane? The min_vfreq/max_vfreq may be 0 if the EDID doesn't have the info, and if the EDID has bogus info, leaving them to 0 is pretty much the only thing we can do. Since we need the !0 check here anyway, I decided to start off with this. BR, Jani. > >> + >> return info->monitor_range.max_vfreq - info->monitor_range.min_vfreq >= 10; > > I've been tempted to get rid of this completely arbitrary 10Hz thing as w= ell. > >> } >>=20=20 >> --=20 >> 2.47.3 --=20 Jani Nikula, Intel