From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E05ECAAA3 for ; Fri, 26 Aug 2022 09:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245499AbiHZJQR (ORCPT ); Fri, 26 Aug 2022 05:16:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245313AbiHZJQR (ORCPT ); Fri, 26 Aug 2022 05:16:17 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CE29D34D4 for ; Fri, 26 Aug 2022 02:16:15 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id n17so1067336wrm.4 for ; Fri, 26 Aug 2022 02:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc; bh=lu7t59Y/6eA1q6IQ9qzo0I3g1dYmEshSQSj7OaC0EW8=; b=dvcCrMXMBs0DCb7ARVAJu7t+jiT75dydGgkrAu9UTeywyKhEzYBOO5aNexjt2pIx0+ K7MkHMPBzQghhTXWSS1Toqy02QbRGmxnsMlmLIHLKwDRkCtYWrwazDyixvtCmIUaSAZZ iYIySOy7OcSPaWAMXutbQ5WDw70DSs3B3xl4BVG848jVIHdiPWMmrWYYhGoc61hzuuyo vlkHZx1wftk9PboEXIyBJEYW2OI9/CDrRzyhy8aTxyJ60no+qBhaMpW5nxdGQJk/3kIc Ooskhseo2rs58jBrHz9XyQNBqp6nDxZHVK+9s1jKtOXEuziecLY7K1ooQb5qK/WtMb99 eKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc; bh=lu7t59Y/6eA1q6IQ9qzo0I3g1dYmEshSQSj7OaC0EW8=; b=tUak1NAQP0VpR2G/degYKhG/YgZbONqH527If4T9CLvhruOt9KmXPWt+6ImDjmV1I7 Z1hc6FC9QjXX82gFWhJmyFk7BQzp3k9vx+ef4HnQDwhGu95LBggeHCvxjpfmVa9Er6ip 6dkH94tXwJEcxF1AhOFr/lEBC/y8GtVHkrcvNG0qIbZZd99gKo8KVxHZl+h9u9X9tNtM MRe6PzHGW4iAJWAC4DLx4g1Sz4x6zzzOcmET61N8LTPRRse4WnbOIDGJ/6pBY1J5+1Tc T9OwYNhyI0fgXLCP7dvxwEUQfbDZsgUnXk/L9jMoHmvaiNB+oFmJT83WiRpuLsEsfphY Zhpw== X-Gm-Message-State: ACgBeo2x+s1IdJ6ePEsy5u3kPD1GTT1ZEfEoiYlxPZzkELlremnqA7l6 4yagc9zy/xZ5dDRvCiz+cBNNEQ== X-Google-Smtp-Source: AA6agR7xPbWca+rrzIehQRM92IvHTy6OG6rwG2aP/MoK/VzAI6XGc0rUVXUwLjGSnAvlheKNOwCTUQ== X-Received: by 2002:a5d:6d8f:0:b0:225:6285:47fb with SMTP id l15-20020a5d6d8f000000b00225628547fbmr4504845wrs.211.1661505373884; Fri, 26 Aug 2022 02:16:13 -0700 (PDT) Received: from ?IPV6:2a01:e0a:b41:c160:5d94:b816:24d3:cd91? ([2a01:e0a:b41:c160:5d94:b816:24d3:cd91]) by smtp.gmail.com with ESMTPSA id t63-20020a1c4642000000b003a673055e68sm8907387wma.0.2022.08.26.02.16.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 02:16:13 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 11:16:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: nicolas.dichtel@6wind.com Subject: Re: 747c143 caused icmp redirect to fail Content-Language: en-US To: Heng Qi , linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org, stable@vger.kernel.org, edwin.brossette@6wind.com, pabeni@redhat.com References: <1661485971-57887-1-git-send-email-hengqi@linux.alibaba.com> From: Nicolas Dichtel Organization: 6WIND In-Reply-To: <1661485971-57887-1-git-send-email-hengqi@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Le 26/08/2022 à 05:52, Heng Qi a écrit : > The detailed description: When testing with selftests/net/icmp_redirect.sh, a redirect exception FAIL occurred for IPv4. > This is not in line with actual expectations. r1 changes the route to the destination network 172.16.2.0/24 from 10.1.1.2 to 172.16.1.254. After h1 sends the ping packet, h1 continues to obtain the route to 172.16.2.2, and the result is not as expected. > This flaw was introduced by 747c14307214b55dbd8250e1ab44cad8305756f1. When this commit is rolled back, the test will pass. > > bug commit: 747c14307214b55dbd8250e1ab44cad8305756f1 Thanks for the report. I will investigate.