public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Wu Bo <bo.wu@vivo.com>, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Wu Bo <wubo.oduw@gmail.com>,
	stable@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH stable] block/mq-deadline: fix different priority request on the same zone
Date: Thu, 16 May 2024 07:45:21 -0600	[thread overview]
Message-ID: <a1c24153-007c-4510-9cb3-bc207e9a75e8@acm.org> (raw)
In-Reply-To: <20240516092838.1790674-1-bo.wu@vivo.com>

On 5/16/24 03:28, Wu Bo wrote:
> Zoned devices request sequential writing on the same zone. That means
> if 2 requests on the saem zone, the lower pos request need to dispatch
> to device first.
> While different priority has it's own tree & list, request with high
> priority will be disptch first.
> So if requestA & requestB are on the same zone. RequestA is BE and pos
> is X+0. ReqeustB is RT and pos is X+1. RequestB will be disptched before
> requestA, which got an ERROR from zoned device.
> 
> This is found in a practice scenario when using F2FS on zoned device.
> And it is very easy to reproduce:
> 1. Use fsstress to run 8 test processes
> 2. Use ionice to change 4/8 processes to RT priority

Hi Wu,

I agree that there is a problem related to the interaction of I/O
priority and zoned storage. A solution with a lower runtime overhead
is available here:
https://lore.kernel.org/linux-block/20231218211342.2179689-1-bvanassche@acm.org/T/#me97b088c535278fe3d1dc5846b388ed58aa53f46

Are you OK with that alternative solution?

Thanks,

Bart.

  reply	other threads:[~2024-05-16 13:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  9:28 [PATCH stable] block/mq-deadline: fix different priority request on the same zone Wu Bo
2024-05-16 13:45 ` Bart Van Assche [this message]
2024-05-17  1:44   ` Wu Bo
2024-05-17 17:53     ` Bart Van Assche
2024-05-18  0:52       ` Wu Bo
2024-05-18  2:14         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1c24153-007c-4510-9cb3-bc207e9a75e8@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=bo.wu@vivo.com \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wubo.oduw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox