From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga03.intel.com ([134.134.136.65]:11192 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726243AbeJAW2E (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 1 Oct 2018 18:28:04 -0400
Subject: Re: [RFT PATCH 2/2] xhci: handle port status events for removed USB3
 hcd
To: Jack Pham <jackp@codeaurora.org>
Cc: Peter Chen <peter.chen@nxp.com>, dl-linux-imx <linux-imx@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Jun Li <jun.li@nxp.com>, "joel@jms.id.au" <joel@jms.id.au>,
        "mrana@codeaurora.org" <mrana@codeaurora.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
References: <20180927013948.GB17520@jackp-linux.qualcomm.com>
 <1538065587-22997-1-git-send-email-mathias.nyman@linux.intel.com>
 <1538065587-22997-2-git-send-email-mathias.nyman@linux.intel.com>
 <43b03dcc-6cae-07b1-402e-f17b63e2f564@linux.intel.com>
 <VI1PR04MB5327EA29B883F2E7CE80E3008BEC0@VI1PR04MB5327.eurprd04.prod.outlook.com>
 <20180928181033.GC17520@jackp-linux.qualcomm.com>
From: Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <a1cfee1d-7e5f-1a40-b285-5eafafec08e2@linux.intel.com>
Date: Mon, 1 Oct 2018 18:52:47 +0300
MIME-Version: 1.0
In-Reply-To: <20180928181033.GC17520@jackp-linux.qualcomm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 28.09.2018 21:10, Jack Pham wrote:
> Hi Mathias,
> 
>>> Jack, Peter, do these patches solve the remove issues you are seeing?
>>
>> At my two USB3 platforms, only apply the 1st patch can fix my problem.  Maybe
>> my USB3 port change interrupt occurs always before removing USB2 HCD.
>>
It's possible yes.

>> Peter
> 
> Ditto. I think the xhci_irq() is getting triggered by something during
> usb_remove_hcd() (usb_disconnect on the root hub?) but is able to
> complete before it returns. That is, the NULL pointer dereference is
> resolved yet I don't see that "ignore port event for removed USB3 hcd"
> message at all.
> 
> Regardless, it's good to have here just in case, so
> Tested-by: Jack Pham <jackp@codeaurora.org>
> 
> Will you be sending this as separate patches for -rc vs -stable?
> 
> Thanks,
> Jack
> 

Thanks, adding tested-by tags.

I'll send them to -rc with stable tag, and then later send a backported version
to older kernel once I have a upstream commit ID I can refer to.

Thanks
-Mathias