From: Matthieu Baerts <matttbe@kernel.org>
To: Sasha Levin <sashal@kernel.org>, stable@vger.kernel.org
Cc: Gang Yan <yangang@kylinos.cn>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH 6.12.y] mptcp: update window_clamp on subflows when SO_RCVBUF is set
Date: Mon, 1 Jun 2026 10:52:08 +1000 [thread overview]
Message-ID: <a4232e10-9e76-4b5e-9f0a-d7ada1d8980c@kernel.org> (raw)
In-Reply-To: <20260601004704.94197-1-sashal@kernel.org>
Hi Sasha,
On 01/06/2026 10:47, Sasha Levin wrote:
> From: Gang Yan <yangang@kylinos.cn>
>
> [ Upstream commit 3a543ae0e2092d5c2085d5f21f7a7dbafdffea3c ]
>
> Add __mptcp_subflow_set_rcvbuf() helper to write the subflow sk_rcvbuf,
> but also to call the recently added tcp_set_rcvbuf() helper to update
> window_clamp. This is needed because the window clap is updated when
> scaling_ratio changes, in tcp_measure_rcv_mss(). Until scaling_ratio
> changes, the subflow is stuck with the old window clamp which may be
> based on a small initial buffer.
>
> Use this new helper in both mptcp_sol_socket_sync_intval() (setsockopt
> path) and sync_socket_options() (new subflow creation path).
>
> Note that this patch depends on commit b025461303d8 ("tcp: update
> window_clamp when SO_RCVBUF is set"): it fixes the issue on TCP side,
> but the same fix is needed on MPTCP side as well.
See my message on the same patch for v7.0: b025461303d8 should be
backported first, but if not, better not to backport this patch.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-06-01 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 11:21 FAILED: patch "[PATCH] mptcp: update window_clamp on subflows when SO_RCVBUF is set" failed to apply to 6.12-stable tree gregkh
2026-06-01 0:47 ` [PATCH 6.12.y] mptcp: update window_clamp on subflows when SO_RCVBUF is set Sasha Levin
2026-06-01 0:52 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4232e10-9e76-4b5e-9f0a-d7ada1d8980c@kernel.org \
--to=matttbe@kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox