From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42516 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752687AbeBSNKR (ORCPT ); Mon, 19 Feb 2018 08:10:17 -0500 Subject: Re: [PATCH 7/9] KVM/VMX: Emulate MSR_IA32_ARCH_CAPABILITIES To: Jim Mattson Cc: David Woodhouse , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , LKML , kvm list , KarimAllah Ahmed , Greg Kroah-Hartman , stable@vger.kernel.org References: <1517938181-15317-1-git-send-email-dwmw@amazon.co.uk> <1517938181-15317-8-git-send-email-dwmw@amazon.co.uk> <4be4e462-61be-53a9-b0e1-3508466d1645@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 19 Feb 2018 14:10:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 16/02/2018 17:29, Jim Mattson wrote: > On Fri, Feb 16, 2018 at 6:18 AM, Paolo Bonzini wrote: > >> Uhm, taking contents from the hardware is wrong (guess why---live >> migration). I'll send a revert of those two lines. > > Hardware seems like a reasonable place to get the default value (cf. > the VMX capability MSRs). There are some differences: - a zero value for ARCH_CAPABILITIES should be safe, while a zero value for VMX capabilities doesn't really make sense. On the contrary, a nonzero value for ARCH_CAPABILITIES is not safe across live migration. - VMX doesn't support live migration; before adding that support we will probably have Tom's patches to retrieve MSR capabilities. Thanks, Paolo > Should these two lines just be moved to > vmx_create_cpu? >