Re: [PATCH v2 01/25] mtd: nand: qcom: fix config error for BCH

[Abhishek Sahu <absahu@codeaurora.org>]

On 2017-08-03 21:26, Boris Brezillon wrote:
> On Wed, 19 Jul 2017 17:17:49 +0530
> Abhishek Sahu <absahu@codeaurora.org> wrote:
> 
>> The configuration for BCH is not correct in the current driver.
>> The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the
>> BCH ECC in which
>> 
>> 	0x1 : BCH_DISABLED
>> 	0x0 : BCH_ENABLED
>> 
>> But currently host->bch_enabled is being assined to BCH_DISABLED.
>> 
>> Fixes: c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
>> ---
>>  drivers/mtd/nand/qcom_nandc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/mtd/nand/qcom_nandc.c 
>> b/drivers/mtd/nand/qcom_nandc.c
>> index 57d483a..bc0408c 100644
>> --- a/drivers/mtd/nand/qcom_nandc.c
>> +++ b/drivers/mtd/nand/qcom_nandc.c
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2016-2017, The Linux Foundation. All rights 
>> reserved.
> 
> Hm, this copyright update is not really related to the changes you're
> describing in the commit message. I'll drop this line from the commit
> (no need to resend it) and ask you to send a separate patch updating 
> the
> copyright. Is that ok?
> 

  The idea was to change the copyright year since we are making
  the changes in this file. If it requires separate patch, then I
  will do the same.

  Also I need to change 'assined' -> assigned in commit text. I can
  update the patch and fix this. I am planning to send the v3 patches
  tomorrow which incorporates all the review comments.

>>   *
>>   * This software is licensed under the terms of the GNU General 
>> Public
>>   * License version 2, as published by the Free Software Foundation, 
>> and
>> @@ -1893,7 +1893,7 @@ static int qcom_nand_host_setup(struct 
>> qcom_nand_host *host)
>>  				| wide_bus << WIDE_FLASH
>>  				| 1 << DEV0_CFG1_ECC_DISABLE;
>> 
>> -	host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE
>> +	host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE
>>  				| 0 << ECC_SW_RESET
>>  				| host->cw_data << ECC_NUM_DATA_BYTES
>>  				| 1 << ECC_FORCE_CLK_OPEN

-- 
Abhishek Sahu