From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39F992DECB0 for ; Tue, 8 Jul 2025 15:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751987455; cv=none; b=uoiB0O1q5aFp75NnMfa3Zxwphuqy/5BHj9gKllGXpAM7wckA5O5zSxvpwysJNXYg/131GU37pE2inalBvXywVBT14Kz5X7FGy7r8gY4Y6jS1q8DahqUFQ9hjF+D6G0kPnYmmz98iR7OSgIjmc8AVUO8U/B6S1dUXyCTboNxCWMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751987455; c=relaxed/simple; bh=fGerUtoQfOMFV13NE4pLJmsZdVSRGXJsQRTXptzxl4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GGXJjixaRvOCcLLbmEzq1FGg+vYgRs9hSIxZ0EyFPYVpVEa4JqD134srqPjVzRXsr+fK4JQ78ilNoh0SIV13IFI0GsT7ndJRmDe6raZ0YHoDpfLmovRRDnvcwNe7w2VjwTj/yQm/GK0TiYPxRtjYAP4UkUNhHZZ30jsJKO17O5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L5v9nJyO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L5v9nJyO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751987450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vF7pB9kaskUnbY7SdEoT1uFkNdrhk58b8baotVEUIFo=; b=L5v9nJyOWopAzBGhpo3oDPzmu1Az+S7aS5YeoMk0Uot+Qrqyr+B477rd3wwHB5jGSyzUK/ ujNVtGp5+4J73yvmn4iREuWEAlBC+yAPzXctIWc6z2srttfodyuCUzsRCIBZhqnuMaNs1b VjhXg7bozapEVHwotvIQRyhGsTmqBpc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-VyrwflheM9ajkIhZ3twXIA-1; Tue, 08 Jul 2025 11:10:49 -0400 X-MC-Unique: VyrwflheM9ajkIhZ3twXIA-1 X-Mimecast-MFC-AGG-ID: VyrwflheM9ajkIhZ3twXIA_1751987447 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-454b907e338so27277615e9.1 for ; Tue, 08 Jul 2025 08:10:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751987447; x=1752592247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vF7pB9kaskUnbY7SdEoT1uFkNdrhk58b8baotVEUIFo=; b=voUVHeSsMJ5pCV+D37VFz89CyqX7O7Ew2vvtIDHQOe2Waq1guNongWH3lFCCub43qK JdxUnyIbWjW+oL0epnNxWO7mhT+khOi4Jfp8p6TJW+FQGo0/03Y6S6D1TXJSoWBIKfx/ P3NK7K3USPFbtbb0WJDfzoW8fdSF9B2gEo/t37Mw2OXU2KPERdFtGMsSNuLdQo3i9o8q if4MGq6B6iP3yQ2gKwi6uDz7cA/wnEAofLEe2gjQmmF5Snxvmv6Ryys2oBnLQDxK4xCU uNcGrizTSOnz33ePagl0FYFPrYgninH/IxLo6jcVRrxvXSeyskaZ6JksPxU9vWAopuWx bkQA== X-Forwarded-Encrypted: i=1; AJvYcCXu33QVgYiJyqq9xYHcQLVyNT3weuzvMxSLst7l6lL4R0UwdJnWVvStPzKiHTgN60Y+k0e1CeY=@vger.kernel.org X-Gm-Message-State: AOJu0YxD0KNGGeow6+Sx68RI+NaobZK0e7r305qYQCBIHr+LUUpLoiVo P8eBkuu5YAem+RoEB77xwGS17vkcrTgKETBeEWnTozECu4qZLj4N7UG+CcUlDTJrHm7UCiKnyCF FjdHlNbRDA56YWlWzFs6UEaPuCPe6omf7ahAtyMwGAcCBWlTG4bjno4uXrQ== X-Gm-Gg: ASbGnctFkQNLL8vmWFHhxmFUhBpeeJdJsGzcMmIHa/8Ov1GtV9Ak3pd90TH8p8fg27T 1AI63HsKt55zeXIKVIhwkhTjmLP285hYEZZeNBwpMy15XpYJ0wQYAOZ5S7FSQUnlOLhAEFbyW69 n7KSKuEtvFUCdynjpcxHFAMcSgIH8JaMFiX3G8uTa0uvEzORIU0Of8W3NKqcnrumJ5XEVl2E5dN Zabw/WG5iuCor+Vya/l3/PFtqdd9cWKbqn8wd3rrllHxTXyUMdExOH4mUzbBTOFXz8Qzehe6MHk 0XUrpWNM4Ntu46KLHNxjlQY3eax4TxDJAGF4vnXk36Ksd910yQSbJkJm8/YZCNGsB6zqM73xNAO dxWKDIvI1W9IXPBOAYMYtQvvjXsId0jZlxkmQyWMJ7WejUNeRYw== X-Received: by 2002:a05:600c:5250:b0:453:a95:f07d with SMTP id 5b1f17b1804b1-454cd4cbed3mr42121235e9.10.1751987446538; Tue, 08 Jul 2025 08:10:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmKLwKgLc+QDyg2LOJPqGWeJ4FiXBWn3lZISABRTzIZSV3j7/eNP1RHFdrHD/ZrgFBqgc0Jg== X-Received: by 2002:a05:600c:5250:b0:453:a95:f07d with SMTP id 5b1f17b1804b1-454cd4cbed3mr42120285e9.10.1751987445940; Tue, 08 Jul 2025 08:10:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47285c903sm13406200f8f.90.2025.07.08.08.10.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 08:10:45 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2025 17:10:44 +0200 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/userfaultfd: fix missing PTE unmap for non-migration entries To: Andrew Morton , Sasha Levin Cc: peterx@redhat.com, aarcange@redhat.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250630031958.1225651-1-sashal@kernel.org> <20250630175746.e52af129fd2d88deecc25169@linux-foundation.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250630175746.e52af129fd2d88deecc25169@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.07.25 02:57, Andrew Morton wrote: > On Sun, 29 Jun 2025 23:19:58 -0400 Sasha Levin wrote: > >> When handling non-swap entries in move_pages_pte(), the error handling >> for entries that are NOT migration entries fails to unmap the page table >> entries before jumping to the error handling label. >> >> This results in a kmap/kunmap imbalance which on CONFIG_HIGHPTE systems >> triggers a WARNING in kunmap_local_indexed() because the kmap stack is >> corrupted. >> >> Example call trace on ARM32 (CONFIG_HIGHPTE enabled): >> WARNING: CPU: 1 PID: 633 at mm/highmem.c:622 kunmap_local_indexed+0x178/0x17c >> Call trace: >> kunmap_local_indexed from move_pages+0x964/0x19f4 >> move_pages from userfaultfd_ioctl+0x129c/0x2144 >> userfaultfd_ioctl from sys_ioctl+0x558/0xd24 >> >> The issue was introduced with the UFFDIO_MOVE feature but became more >> frequent with the addition of guard pages (commit 7c53dfbdb024 ("mm: add >> PTE_MARKER_GUARD PTE marker")) which made the non-migration entry code >> path more commonly executed during userfaultfd operations. >> >> Fix this by ensuring PTEs are properly unmapped in all non-swap entry >> paths before jumping to the error handling label, not just for migration >> entries. > > I don't get it. > >> --- a/mm/userfaultfd.c >> +++ b/mm/userfaultfd.c >> @@ -1384,14 +1384,15 @@ static int move_pages_pte(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, >> >> entry = pte_to_swp_entry(orig_src_pte); >> if (non_swap_entry(entry)) { >> + pte_unmap(src_pte); >> + pte_unmap(dst_pte); >> + src_pte = dst_pte = NULL; >> if (is_migration_entry(entry)) { >> - pte_unmap(src_pte); >> - pte_unmap(dst_pte); >> - src_pte = dst_pte = NULL; >> migration_entry_wait(mm, src_pmd, src_addr); >> err = -EAGAIN; >> - } else >> + } else { >> err = -EFAULT; >> + } >> goto out; > > where we have > > out: > ... > if (dst_pte) > pte_unmap(dst_pte); > if (src_pte) > pte_unmap(src_pte); AI slop? -- Cheers, David / dhildenb