From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kirill Marinushkin <k.marinushkin@gmail.com>,
alsa-devel@alsa-project.org,
Pan Xiuli <xiuli.pan@linux.intel.com>,
stable@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>
Subject: Re: [alsa-devel] Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree
Date: Tue, 27 Feb 2018 07:13:17 -0800 [thread overview]
Message-ID: <a5bdbfc8-6abd-6757-6afd-68e27d6a9697@linux.intel.com> (raw)
In-Reply-To: <20180227103848.GA11822@sirena.org.uk>
On 2/27/18 2:38 AM, Mark Brown wrote:
> On Mon, Feb 26, 2018 at 06:30:15PM -0800, Pierre-Louis Bossart wrote:
>> On 2/26/18 10:34 AM, Kirill Marinushkin wrote:
>
>>> According to the comment, the existing functionality works correctly "WRT the
>>> interface". The suggested commit doesn't fix the behaviour: instead, it reverts
>>> the logic to "WRT the codec". But the existing implementation is also valid.
>
>> Look at all the machine drivers, they always use the mask by looking at the
>> codec side. The comment on top means that the SOC side ('the interface') is
>> the dual of the codec side.
>
>> This issue was found during the development of SOF (Sound Open Firmware)
>> where we get the reverse of the intended behavior when using the same
>> conventions in topology files as in machine drivers.
>
> Is this perhaps something that the earlier firmware is handling inside
> the firmware?
For SKL+ the SSP settings come from binary blobs read from ACPI/NHLT
tables so I am wondering if this inversion is compensated for in the
tools used to generate the blobs.
next prev parent reply other threads:[~2018-02-27 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1519336888-71831-1-git-send-email-xiuli.pan@linux.intel.com>
2018-02-26 11:17 ` Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree Mark Brown
2018-02-26 18:34 ` Kirill Marinushkin
2018-02-26 19:47 ` Mark Brown
2018-02-27 4:38 ` Kirill Marinushkin
2018-02-27 2:30 ` [alsa-devel] " Pierre-Louis Bossart
2018-02-27 4:50 ` Kirill Marinushkin
2018-02-27 10:38 ` Mark Brown
2018-02-27 15:13 ` Pierre-Louis Bossart [this message]
2018-02-27 15:57 ` Mark Brown
2018-02-28 6:22 ` Pierre-Louis Bossart
2018-03-12 16:14 ` Mark Brown
2018-03-12 23:29 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5bdbfc8-6abd-6757-6afd-68e27d6a9697@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=k.marinushkin@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox