From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com ([134.134.136.126]:43923 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbeB0PNK (ORCPT ); Tue, 27 Feb 2018 10:13:10 -0500 Subject: Re: [alsa-devel] Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree To: Mark Brown Cc: Kirill Marinushkin , alsa-devel@alsa-project.org, Pan Xiuli , stable@vger.kernel.org, Liam Girdwood References: <20180226183407.22335-1-k.marinushkin@gmail.com> <20180227103848.GA11822@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Tue, 27 Feb 2018 07:13:17 -0800 MIME-Version: 1.0 In-Reply-To: <20180227103848.GA11822@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 2/27/18 2:38 AM, Mark Brown wrote: > On Mon, Feb 26, 2018 at 06:30:15PM -0800, Pierre-Louis Bossart wrote: >> On 2/26/18 10:34 AM, Kirill Marinushkin wrote: > >>> According to the comment, the existing functionality works correctly "WRT the >>> interface". The suggested commit doesn't fix the behaviour: instead, it reverts >>> the logic to "WRT the codec". But the existing implementation is also valid. > >> Look at all the machine drivers, they always use the mask by looking at the >> codec side. The comment on top means that the SOC side ('the interface') is >> the dual of the codec side. > >> This issue was found during the development of SOF (Sound Open Firmware) >> where we get the reverse of the intended behavior when using the same >> conventions in topology files as in machine drivers. > > Is this perhaps something that the earlier firmware is handling inside > the firmware? For SKL+ the SSP settings come from binary blobs read from ACPI/NHLT tables so I am wondering if this inversion is compensated for in the tools used to generate the blobs.