From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
snitzer@redhat.com, hch@lst.de, xni@redhat.com,
mariusz.dabrowski@intel.com
Subject: Re: [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size
Date: Fri, 9 Nov 2018 06:24:29 -0700 [thread overview]
Message-ID: <a6256e27-15ec-23f3-104f-a4f5429ffb37@kernel.dk> (raw)
In-Reply-To: <20181107005509.GA3531@ming.t460p>
On 11/6/18 5:55 PM, Ming Lei wrote:
> On Tue, Nov 06, 2018 at 04:48:13PM +0000, Rui Salvaterra wrote:
>> On Mon, 5 Nov 2018 at 03:41, Ming Lei <ming.lei@redhat.com> wrote:
>>>
>>> V2 addresses Christoph's comment by introducing bio_allowed_max_sectors().
>>>
>>> Ping...
>>>
>>> Thanks,
>>> Ming
>>
>> Hi, Ming,
>>
>> Sorry for the delay. I tested your V2 against Linux 4.20-rc1 and
>> everything seems fine. FWIW, V2 is also
>>
>> Tested-by: Rui Salvaterra <rsalvaterra@gmail.com>
>
> Rui, thanks for your test on V2.
>
> Jens, what do you think about this patchset?
I waffled on this a bit... I generally don't like cleanup patches for
fixes that are going into the current series. Those kinds of patches
should be as short and sweet as possible, and cleanup part usually ends
up being the problematic one, ironically enough. But it looks fine to
me, so I've put it in.
--
Jens Axboe
prev parent reply other threads:[~2018-11-09 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 12:57 [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size Ming Lei
2018-10-29 12:57 ` [PATCH V2 1/3] block: make sure discard " Ming Lei
2018-10-29 12:57 ` [PATCH V2 3/3] block: make sure writesame " Ming Lei
2018-11-05 3:41 ` [PATCH V2 0/3] block: make sure discard/writesame " Ming Lei
2018-11-06 16:48 ` Rui Salvaterra
2018-11-07 0:55 ` Ming Lei
2018-11-09 13:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6256e27-15ec-23f3-104f-a4f5429ffb37@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
--cc=ming.lei@redhat.com \
--cc=rsalvaterra@gmail.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox