From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A6EC282D7 for ; Wed, 30 Jan 2019 10:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A019218A4 for ; Wed, 30 Jan 2019 10:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hL22gjT7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730683AbfA3Kfc (ORCPT ); Wed, 30 Jan 2019 05:35:32 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38696 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727500AbfA3Kfc (ORCPT ); Wed, 30 Jan 2019 05:35:32 -0500 Received: by mail-wr1-f68.google.com with SMTP id v13so25407807wrw.5 for ; Wed, 30 Jan 2019 02:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=RANF02NbqISA0pcxiCdH3+Zum71ozXszsFyIMhb3nP0=; b=hL22gjT7EWEEQBPN8RmNEDPnsMP/C5WWpt+mzTSdomNAnsXTS9zHBH68g9H75ihK7u XYu365QXfhsn8+h9+r3gpqiMdOnzED+80a+OmCBC7/5YeI4LVhAkFq/ZdX8qQUq/FeE1 2fXCu3qG9w+Z3gRLR/Yn1gvLzOGbI8woHAJKncrmip9jxd0uVHZWKqLNB8foBt8yjXtd 6Dujd9+SowIwprSXQMbpoGkNaNSgl1rHkWKBN74kBK93z2Y7ltQhZQfqyhim64Fab7ec sKeAzBHZCOkg9slmW9FxwRiRoA+VCy3vMtuWQnaNFLHuEgqiNbHbpi6bTHMfO1kMB4x0 j1cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=RANF02NbqISA0pcxiCdH3+Zum71ozXszsFyIMhb3nP0=; b=ONDTgtw9e7RCqEpKUv9qPdUaFRvRT6Y5Q/r6dSRCkTQ9v9SozhYe6XB8FpdDYwy4si 4H3v0gCp4fIBpV6Cx90TSGZQdGcz9E3mJDXiSCFFJ5dc0kPli8EXAW6Br3TtbQfTzjY5 XZK930DlpbCdu7MhQLptp8cVMZPez7qnIQRaUQ4FSq2xfk/siquuUTEMycGYeFhhjPJY u2moAevqMDM+Ayl0CKyA+L/j5Eh7lN+HLKJlfT++5p2yQJrsMFYFcZ3ttwbUb4wrMwJL 9RpCiRxrQw517+al6NDQ53iNG067rRzoPG9aAgISsNhelXFc1sY1zlQtmeUJSQUOaguJ 1d+w== X-Gm-Message-State: AJcUukflLjMqColDD9siMNoEmvp0WbyVILPHPM6eKhUKk0OEevXGkXF0 Bx5QAutl3cjUk8g1NRBEvPj5Z4/J X-Google-Smtp-Source: ALg8bN6KMD/a67t5AXlUstXrIMbWx7H6iBD8q03gT7lZIc35WzzSmAvv4PlXi3A/u9tuXQNlXGcnSw== X-Received: by 2002:adf:8231:: with SMTP id 46mr25995720wrb.327.1548844530316; Wed, 30 Jan 2019 02:35:30 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id o64sm1511101wmo.47.2019.01.30.02.35.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 02:35:29 -0800 (PST) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines" To: "Wentland, Harry" , Alex Deucher , "amd-gfx@lists.freedesktop.org" Cc: "Deucher, Alexander" , "stable@vger.kernel.org" References: <20190129165725.31062-1-alexander.deucher@amd.com> <05ee719f-ac7e-bcb0-59f0-920b72f65524@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 30 Jan 2019 11:35:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <05ee719f-ac7e-bcb0-59f0-920b72f65524@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Am 29.01.19 um 19:28 schrieb Wentland, Harry: > On 2019-01-29 11:57 a.m., Alex Deucher wrote: >> This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a. >> >> Causes a crash. >> >> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487 >> Signed-off-by: Alex Deucher >> Cc: stable@vger.kernel.org # 4.19 > Thanks for finding and reverting. > > Reviewed-by: Harry Wentland Reviewed-by: Christian König I find it really troubling that we run into so many issues with that. Christian. > > Harry > >> --- >> drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +- >> drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile >> index dc85a3c088af..95f332ee3e7e 100644 >> --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile >> +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile >> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),) >> cc_stack_align := -mstack-alignment=16 >> endif >> >> -calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align) >> +calcs_ccflags := -mhard-float -msse $(cc_stack_align) >> >> CFLAGS_dcn_calcs.o := $(calcs_ccflags) >> CFLAGS_dcn_calc_auto.o := $(calcs_ccflags) >> diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile >> index 33c7d7588712..d97ca6528f9d 100644 >> --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile >> +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile >> @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),) >> cc_stack_align := -mstack-alignment=16 >> endif >> >> -dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align) >> +dml_ccflags := -mhard-float -msse $(cc_stack_align) >> >> CFLAGS_display_mode_lib.o := $(dml_ccflags) >> CFLAGS_display_pipe_clocks.o := $(dml_ccflags) >> > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx