From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:40484 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754964AbdK2OkP (ORCPT ); Wed, 29 Nov 2017 09:40:15 -0500 Subject: Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails. To: Thomas Voegtle , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org References: <20171128111603.62757-1-maarten.lankhorst@linux.intel.com> <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local> From: Maarten Lankhorst Message-ID: Date: Wed, 29 Nov 2017 15:40:04 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: stable-owner@vger.kernel.org List-ID: Op 28-11-17 om 16:13 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Daniel Vetter wrote: > >> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >>> Some drivers like i915 start with crtc's enabled, but with deferred >>> fbcon setup they were no longer disabled as part of fbdev setup. >>> Headless units could no longer enter pc3 state because the crtc was >>> still enabled. >>> >>> Fix this by calling restore_fbdev_mode when we would have called >>> it otherwise once during initial fbdev setup. >>> >>> Signed-off-by: Maarten Lankhorst >>> Fixes: ca91a2758fce ("drm/fb-helper: Support deferred setup") >> >> Please use dim fixes to get a more complete Cc: list for regression fixes. >> >>> Cc: # v4.14+ >>> Reported-by: Thomas Voegtle >> >> Reviewed-by: Daniel Vetter >> >> But please confirm with the reporter that it indeed fixes the issue before >> pushing. >> -Daniel > > I re-checked the latest version of the patch and it indeed fixes the problem. > > Thanks, > >    Thomas > Pushed, thanks for the report. :) ~Maarten