* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
@ 2023-12-05 22:01 ` Florian Fainelli
2023-12-06 1:55 ` Dominique Martinet
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2023-12-05 22:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml
On 12/5/23 11:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
2023-12-05 22:01 ` Florian Fainelli
@ 2023-12-06 1:55 ` Dominique Martinet
2023-12-06 11:37 ` Naresh Kamboju
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Dominique Martinet @ 2023-12-06 1:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
Greg Kroah-Hartman wrote on Wed, Dec 06, 2023 at 04:22:23AM +0900:
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
Tested on:
- arm i.MX6ULL (Armadillo 640)
- arm64 i.MX8MP (Armadillo G4)
No obvious regression in dmesg or basic tests:
Tested-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
--
Dominique Martinet | Asmadeus
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
2023-12-05 22:01 ` Florian Fainelli
2023-12-06 1:55 ` Dominique Martinet
@ 2023-12-06 11:37 ` Naresh Kamboju
2023-12-06 11:50 ` Jon Hunter
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Naresh Kamboju @ 2023-12-06 11:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
On Wed, 6 Dec 2023 at 00:52, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
## Build
* kernel: 5.10.203-rc3
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.10.y
* git commit: 3e5897d7b3637fe06435b1b778ed77c76ef7612d
* git describe: v5.10.202-132-g3e5897d7b363
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.202-132-g3e5897d7b363
## Test Regressions (compared to v5.10.202)
## Metric Regressions (compared to v5.10.202)
## Test Fixes (compared to v5.10.202)
## Metric Fixes (compared to v5.10.202)
## Test result summary
total: 86943, pass: 67634, fail: 3147, skip: 16110, xfail: 52
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 117 total, 116 passed, 1 failed
* arm64: 44 total, 43 passed, 1 failed
* i386: 35 total, 35 passed, 0 failed
* mips: 24 total, 24 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 25 total, 25 passed, 0 failed
* riscv: 11 total, 11 passed, 0 failed
* s390: 12 total, 12 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 8 total, 8 passed, 0 failed
* x86_64: 38 total, 38 passed, 0 failed
## Test suites summary
* boot
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timens
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* libgpiod
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
* v4l2-compliance
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2023-12-06 11:37 ` Naresh Kamboju
@ 2023-12-06 11:50 ` Jon Hunter
2023-12-06 16:31 ` Shuah Khan
2023-12-06 23:00 ` Alexey Khoroshilov
5 siblings, 0 replies; 11+ messages in thread
From: Jon Hunter @ 2023-12-06 11:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, linux-tegra,
stable
On Wed, 06 Dec 2023 04:22:23 +0900, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
68 tests: 68 pass, 0 fail
Linux version: 5.10.203-rc3-g3e5897d7b363
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2023-12-06 11:50 ` Jon Hunter
@ 2023-12-06 16:31 ` Shuah Khan
2023-12-09 11:44 ` Greg Kroah-Hartman
2023-12-06 23:00 ` Alexey Khoroshilov
5 siblings, 1 reply; 11+ messages in thread
From: Shuah Khan @ 2023-12-06 16:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, Shuah Khan
On 12/5/23 12:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled. Fails to boot up. Boot hangs during systemd init sequence.
I am debugging this and will update you.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-06 16:31 ` Shuah Khan
@ 2023-12-09 11:44 ` Greg Kroah-Hartman
2023-12-12 16:17 ` Shuah Khan
0 siblings, 1 reply; 11+ messages in thread
From: Greg Kroah-Hartman @ 2023-12-09 11:44 UTC (permalink / raw)
To: Shuah Khan
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
On Wed, Dec 06, 2023 at 09:31:48AM -0700, Shuah Khan wrote:
> On 12/5/23 12:22, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.203 release.
> > There are 131 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Compiled. Fails to boot up. Boot hangs during systemd init sequence.
> I am debugging this and will update you.
Anything come of this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-09 11:44 ` Greg Kroah-Hartman
@ 2023-12-12 16:17 ` Shuah Khan
0 siblings, 0 replies; 11+ messages in thread
From: Shuah Khan @ 2023-12-12 16:17 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, Shuah Khan
On 12/9/23 04:44, Greg Kroah-Hartman wrote:
> On Wed, Dec 06, 2023 at 09:31:48AM -0700, Shuah Khan wrote:
>> On 12/5/23 12:22, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.10.203 release.
>>> There are 131 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Compiled. Fails to boot up. Boot hangs during systemd init sequence.
>> I am debugging this and will update you.
>
> Anything come of this?
>
Still working on it. I upgraded distro on my system which is complicating
things. Not sure if this is related distro upgrade or not. I suspect it
is distro related since 5.10.202 which booted just fine prior to distro
upgrade is behaving the same way.
For now ignore this and I will update you.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-05 19:22 [PATCH 5.10 000/131] 5.10.203-rc3 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2023-12-06 16:31 ` Shuah Khan
@ 2023-12-06 23:00 ` Alexey Khoroshilov
2023-12-08 6:33 ` Greg Kroah-Hartman
2023-12-08 6:47 ` Greg Kroah-Hartman
5 siblings, 2 replies; 11+ messages in thread
From: Alexey Khoroshilov @ 2023-12-06 23:00 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, lvc-project@linuxtesting.org
On 05.12.2023 22:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.203 release.
> There are 131 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
It seems something is seriously broken in this release.
There are patches already applied in 5.10.202 that are in 5.10.203-rc3
transformed in some strange way, e.g.
Neil Armstrong <narmstrong@baylibre.com>
tty: serial: meson: retrieve port FIFO size from DT
commit 980c3135f1ae6fe686a70c8ba78eb1bb4bde3060 in 5.10.202
diff --git a/drivers/tty/serial/meson_uart.c
b/drivers/tty/serial/meson_uart.c
index d06653493f0e..78bda91a6bf1 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -728,6 +728,7 @@ static int meson_uart_probe(struct platform_device
*pdev)
{
struct resource *res_mem, *res_irq;
struct uart_port *port;
+ u32 fifosize = 64; /* Default is 64, 128 for EE UART_0 */
int ret = 0;
if (pdev->dev.of_node)
@@ -755,6 +756,8 @@ static int meson_uart_probe(struct platform_device
*pdev)
if (!res_irq)
return -ENODEV;
+ of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
+
if (meson_ports[pdev->id]) {
dev_err(&pdev->dev, "port %d already allocated\n",
pdev->id);
return -EBUSY;
@@ -784,7 +787,7 @@ static int meson_uart_probe(struct platform_device
*pdev)
port->type = PORT_MESON;
port->x_char = 0;
port->ops = &meson_uart_ops;
- port->fifosize = 64;
+ port->fifosize = fifosize;
meson_ports[pdev->id] = port;
platform_set_drvdata(pdev, port);
vs.
commit 71feab929585232694b4f2fb7d70abde4edc581e in 5.10.203-rc3
diff --git a/drivers/tty/serial/meson_uart.c
b/drivers/tty/serial/meson_uart.c
index bb66a3f06626..c44ab21a9b7d 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -765,6 +765,8 @@ static int meson_uart_probe(struct platform_device
*pdev)
of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
has_rtscts = of_property_read_bool(pdev->dev.of_node,
"uart-has-rtscts");
+ of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
+
if (meson_ports[pdev->id]) {
dev_err(&pdev->dev, "port %d already allocated\n",
pdev->id);
return -EBUSY;
Found by Linux Verification Center (linuxtesting.org) with SVACE
See also:
Qu Huang <qu.huang@linux.dev>
drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL
Axel Lin <axel.lin@ingics.com>
i2c: sun6i-p2wi: Prevent potential division by zero
Takashi Iwai <tiwai@suse.de>
media: imon: fix access to invalid resource for the second interface
Also there is a strange pair:
Patrick Thompson <ptf@google.com>
net: r8169: Disable multicast filter for RTL8168H and RTL8107E
Heiner Kallweit <hkallweit1@gmail.com>
Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E"
--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-06 23:00 ` Alexey Khoroshilov
@ 2023-12-08 6:33 ` Greg Kroah-Hartman
2023-12-08 6:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2023-12-08 6:33 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
lvc-project@linuxtesting.org
On Thu, Dec 07, 2023 at 02:00:06AM +0300, Alexey Khoroshilov wrote:
> On 05.12.2023 22:22, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.203 release.
> > There are 131 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> It seems something is seriously broken in this release.
>
> There are patches already applied in 5.10.202 that are in 5.10.203-rc3
> transformed in some strange way, e.g.
>
> Neil Armstrong <narmstrong@baylibre.com>
> tty: serial: meson: retrieve port FIFO size from DT
>
>
> commit 980c3135f1ae6fe686a70c8ba78eb1bb4bde3060 in 5.10.202
Odd, yeah, something is off here, let me look into it after my coffee
has kicked in...
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5.10 000/131] 5.10.203-rc3 review
2023-12-06 23:00 ` Alexey Khoroshilov
2023-12-08 6:33 ` Greg Kroah-Hartman
@ 2023-12-08 6:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2023-12-08 6:47 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
lvc-project@linuxtesting.org
On Thu, Dec 07, 2023 at 02:00:06AM +0300, Alexey Khoroshilov wrote:
> On 05.12.2023 22:22, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.203 release.
> > There are 131 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> It seems something is seriously broken in this release.
>
> There are patches already applied in 5.10.202 that are in 5.10.203-rc3
> transformed in some strange way, e.g.
>
> Neil Armstrong <narmstrong@baylibre.com>
> tty: serial: meson: retrieve port FIFO size from DT
>
>
> commit 980c3135f1ae6fe686a70c8ba78eb1bb4bde3060 in 5.10.202
>
> diff --git a/drivers/tty/serial/meson_uart.c
> b/drivers/tty/serial/meson_uart.c
> index d06653493f0e..78bda91a6bf1 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -728,6 +728,7 @@ static int meson_uart_probe(struct platform_device
> *pdev)
> {
> struct resource *res_mem, *res_irq;
> struct uart_port *port;
> + u32 fifosize = 64; /* Default is 64, 128 for EE UART_0 */
> int ret = 0;
>
> if (pdev->dev.of_node)
> @@ -755,6 +756,8 @@ static int meson_uart_probe(struct platform_device
> *pdev)
> if (!res_irq)
> return -ENODEV;
>
> + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
> +
> if (meson_ports[pdev->id]) {
> dev_err(&pdev->dev, "port %d already allocated\n",
> pdev->id);
> return -EBUSY;
> @@ -784,7 +787,7 @@ static int meson_uart_probe(struct platform_device
> *pdev)
> port->type = PORT_MESON;
> port->x_char = 0;
> port->ops = &meson_uart_ops;
> - port->fifosize = 64;
> + port->fifosize = fifosize;
>
> meson_ports[pdev->id] = port;
> platform_set_drvdata(pdev, port);
>
> vs.
>
> commit 71feab929585232694b4f2fb7d70abde4edc581e in 5.10.203-rc3
>
> diff --git a/drivers/tty/serial/meson_uart.c
> b/drivers/tty/serial/meson_uart.c
> index bb66a3f06626..c44ab21a9b7d 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -765,6 +765,8 @@ static int meson_uart_probe(struct platform_device
> *pdev)
> of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
> has_rtscts = of_property_read_bool(pdev->dev.of_node,
> "uart-has-rtscts");
>
> + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
> +
> if (meson_ports[pdev->id]) {
> dev_err(&pdev->dev, "port %d already allocated\n",
> pdev->id);
> return -EBUSY;
>
>
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE
>
>
>
> See also:
>
> Qu Huang <qu.huang@linux.dev>
> drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL
>
> Axel Lin <axel.lin@ingics.com>
> i2c: sun6i-p2wi: Prevent potential division by zero
>
> Takashi Iwai <tiwai@suse.de>
> media: imon: fix access to invalid resource for the second interface
>
>
> Also there is a strange pair:
>
> Patrick Thompson <ptf@google.com>
> net: r8169: Disable multicast filter for RTL8168H and RTL8107E
>
> Heiner Kallweit <hkallweit1@gmail.com>
> Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E"
>
Ok, I dropped all of these and manually verified that there were no
other duplicates. thanks for catching them and letting us know.
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread