From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5755622301 for ; Wed, 29 Apr 2026 02:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777428894; cv=none; b=oZPBJ57D6+Lkzqgmyxz7RZ45es2gmUKp3FaSCao6iWYZhdcSkkC+Qb6m5chohGVEkkFp5kkrSM93J6x5xNWjIfbeoUwLzEYnd55bPo4Zp7kEs6JrM+ZUyoqWRyTZeSvll+tRsSBIzeq6KYUiOKmJ4aZKe0wSl0GgDrjvV5jncHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777428894; c=relaxed/simple; bh=p54sB/AUYJK/XSKJbtpUI/rdZbOSQjmVqUdZNAW1ctk=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=dcVQqMOjwtmKvEzvjsDvS4TD/0e5falT7QvP2hBJOfcXmw4bHHd3VDBICyuFP7xmiy0asWX/Gb+imU8kfg/7puczVTldZGE54wcTm8WaMmdHGxjvtRvj92pMjxxVHZ0KD942tkbJ5xFT7iDLgOA8tf/jOJllUICXJN8/iWe2jE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lgDK40ym; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lgDK40ym" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B7EC2BCB7; Wed, 29 Apr 2026 02:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777428893; bh=p54sB/AUYJK/XSKJbtpUI/rdZbOSQjmVqUdZNAW1ctk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=lgDK40ym4JvlG15PLvTw/2n+hPSj8KOyZIhs+BoPUow1mXW7S10Dbuy7tpQzAOgdO vLGcBGSR+ilSYMbdpTzu+vQdx/XFTMf20pIqHRP6M0kojIdz2RJ7qBg3hXMxYMWSaL ygxBkwEU1v7br/EjNm287WGr/qpMI03CM1zPYO2ADPJiT3S4uCPFautrPX0qC33x2J x+UY93EZ4CYdLNtCiEvLVjUbJ6hjtfTgfct3Yeisggsyw8F1fD6jOSuLE3Dzdk4iWd XEkj5aduwedR1UN+3DKjz4V36nbBQPyOA3SrpXvXmxu8/LYK6G4Whmuy2kn7wefD5h EfohuvmQIYOhQ== Message-ID: Date: Wed, 29 Apr 2026 10:14:47 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, Yongpeng Yang , stable@vger.kernel.org Subject: Re: [PATCH v2] f2fs: fix incorrect FI_NO_EXTENT handling in __destroy_extent_node() To: Yongpeng Yang , Jaegeuk Kim References: <20260427131050.1526593-2-monty_pavel@sina.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260427131050.1526593-2-monty_pavel@sina.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/26 21:10, Yongpeng Yang wrote: > From: Yongpeng Yang > > When __destroy_extent_node() sets the inode flag FI_NO_EXTENT, it does > not reset the length of the largest extent to 0 and update the inode > folio. Since modifications to the extent tree are disallowed afterward, > the cached largest extent may become stale. This can trigger the > following error in xfstests generic/388: > > F2FS-fs (dm-0): sanity_check_extent_cache: inode (ino=1761) extent info [220057, 57, 6] is incorrect, run fsck to fix > > In the f2fs_drop_inode path, __destroy_extent_node() does not need to > guarantee that et->node_cnt is 0, because concurrency with writeback > is expected in this path, and writeback may update the extent cache. > > This patch reverts commit ed78aeebef05 ("f2fs: fix node_cnt race between > extent node destroy and writeback"), and remove the unnecessary zero > check of et->node_cnt. > > Fixes: ed78aeebef05 ("f2fs: fix node_cnt race between extent node destroy and writeback") > Cc: stable@vger.kernel.org > Reported-by: Chao Yu > Suggested-by: Chao Yu > Signed-off-by: Yongpeng Yang Reviewed-by: Chao Yu Thanks,